fix(binder): preserve reservations during bind cache lag - #2049
Closed
davidLif wants to merge 1 commit into
Closed
Conversation
Signed-off-by: davidLif <davidshani12@gmail.com>
|
Total coverage: 54.5% -> 54.5% (delta 0.00%) Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
gshaibi
reviewed
Aug 10, 2026
| } | ||
|
|
||
| for _, gpuGroup := range bindRequest.Spec.SelectedGPUGroups { | ||
| if slices.Contains(resources.GetGpuGroups(pod), gpuGroup) { |
Member
There was a problem hiding this comment.
What is the effect of this loop? We return true afterwards anyway, right?
|
|
||
| func (rsc *service) hasLivePodForBindRequest(ctx context.Context, bindRequest *schedulingv1alpha2.BindRequest) (bool, error) { | ||
| pod := &v1.Pod{} | ||
| err := rsc.kubeClient.Get(ctx, client.ObjectKey{ |
Member
There was a problem hiding this comment.
Consider also matching the UID of the pod (against the BindRequests's OwnerReference) since a pod can be recreated with the same name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes reservation pod cleanup during BindRequest/pod cache lag.
When
SyncForGpuGroupsees a reservation pod but does not see any fraction pods for the GPU group, it uses BindRequests as a guard before deleting the reservation. The previous guard ignored succeeded BindRequests. In practice, the BindRequest status can advance before the pod GPU-group label is visible through the client cache, so cleanup could delete the reservation pod in the middle of a successful bind.This keeps succeeded BindRequests protective while their target pod is still live. Failed BindRequests and succeeded BindRequests whose pod is gone or terminal do not protect the reservation.
Related Issues
N/A
Checklist
make changelog(or applied theskip-changeloglabel). Do not editCHANGELOG.mddirectly — pending fragments are folded into it at release time.Breaking Changes
None.
Additional Notes
Validation run: