fix(scheduler): namespace PodGroup identities - #2095
Open
nvyutwu wants to merge 1 commit into
Open
Conversation
Signed-off-by: Yuting Wu (DLAlgo) <yutwu@nvidia.com>
nvyutwu
marked this pull request as ready for review
August 22, 2026 19:11
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PodGroup is a namespaced Kubernetes resource, but the scheduler cache used only
PodGroup.Namefor three related identities:PodGroupInfosmap, andAs a result, same-named PodGroups in different namespaces collided. One snapshot entry overwrote the other and pods from both namespaces could be attached to one group. This could make topology allocations owned by one workload appear to belong to another workload and incorrectly remove otherwise available nodes from consideration.
This change introduces a canonical
namespace/namePodGroup ID and uses it consistently at the cache boundary. Pods without a PodGroup annotation retain the existing empty index key.A regression test creates
live/shared-nameandshadow/shared-namewith one pod each. Before the fix, the test observes one merged group; after the fix, it observes two isolated groups whose pods carry the correct namespaced job ID.Related Issues
N/A
Checklist
make changelogBreaking Changes
None. The change affects internal scheduler cache keys only.
Additional Notes
Validation on an x86_64 Linux workstation:
go test ./pkg/scheduler/... -count=1go vet ./pkg/scheduler/...golangci-lint run -v -c .golangci.yaml ./pkg/scheduler/...go build -buildvcs=false ./cmd/schedulerThe regression is deterministic cache bookkeeping and does not require a multi-node GPU cluster.