Skip to content

Commit dcc0818

Browse files
committed
ci: correct the secret descriptions to say write, not just pull
Review feedback: the descriptions said the credential was for pulling the image under test, but this workflow also pushes a bundles-test image to the same repository. A caller reading only the description could reasonably grant a read-only credential and hit a confusing failure late in the run, after the image had already been built and booted. Says write explicitly now, and names the repository. Signed-off-by: Mauro Morales <contact@mauromorales.com>
1 parent 9eeec06 commit dcc0818

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

.github/workflows/reusable-qemu-test.yaml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,13 @@ on:
3939

4040
secrets:
4141
QUAY_USERNAME:
42-
description: "Registry user for pulling the image under test from ci-temp-images."
42+
description: |
43+
Registry user for quay.io/kairos/ci-temp-images. Needs WRITE, not just
44+
read: this workflow pulls the image under test and also pushes a
45+
bundles-test image back to the same repository.
4346
required: true
4447
QUAY_PASSWORD:
45-
description: "Registry token matching QUAY_USERNAME."
48+
description: "Registry token matching QUAY_USERNAME. Same write scope."
4649
required: true
4750

4851
jobs:

0 commit comments

Comments
 (0)