Merge pull request #22 from kaiso/support/hotfix/#21

[bug][#21] child document is not loaded when the joinproperty and the…

Author: kaiso

src/main/java/io/github/kaiso/relmongo/events/callback/PersistentPropertyLazyLoadingCallback.java

@@ -53,12 +53,13 @@ public PersistentPropertyLazyLoadingCallback(Object source, DBObject document, M
     public void doWith(Field field) throws IllegalAccessException {
         ReflectionUtils.makeAccessible(field);
 
-        if (DocumentUtils.isLoaded(document.get(field.getName()))) {
-            return;
-        }
-
         if ((field.isAnnotationPresent(OneToMany.class) && FetchType.LAZY.equals(field.getAnnotation(OneToMany.class).fetch()))
                 || (field.isAnnotationPresent(OneToOne.class) && FetchType.LAZY.equals(field.getAnnotation(OneToOne.class).fetch()))) {
+            
+            if (DocumentUtils.isLoaded(document.get(field.getName()))) {
+                return;
+            }
+            
             String joinPropertyName;
             try {
                 joinPropertyName = field.getAnnotation(JoinProperty.class).name();

src/main/java/io/github/kaiso/relmongo/events/callback/PersistentPropertyLoadingCallback.java

@@ -71,7 +71,7 @@ private void loadAssociation(Field field, FetchType fetchType, Class<?> annotati
 
             ids = ((BasicDBObject) source).get(name);
 
-            if (DocumentUtils.isLoaded(((BasicDBObject) source).get(field.getName())) || ids == null || ((DBObject)ids).keySet().isEmpty()) {
+            if (ids == null || DocumentUtils.isLoaded(((BasicDBObject) source).get(field.getName())) || ((DBObject)ids).keySet().isEmpty()) {
                 return;
             }
 

src/main/java/io/github/kaiso/relmongo/mongo/DocumentUtils.java

@@ -16,15 +16,15 @@
 package io.github.kaiso.relmongo.mongo;
 
 import com.mongodb.BasicDBObject;
+import com.mongodb.DBObject;
+
+import io.github.kaiso.relmongo.util.RelMongoConstants;
 
 import org.bson.types.ObjectId;
 
 import java.util.Collection;
 
 public final class DocumentUtils {
-    
-    
-    
 
     private DocumentUtils() {
         super();
@@ -37,10 +37,27 @@ private DocumentUtils() {
      * @return
      */
     public static boolean isLoaded(Object obj) {
-        return (obj != null && Collection.class.isAssignableFrom(obj.getClass()) && !((Collection<?>) obj).isEmpty()) || (obj != null);
+        if (obj != null) {
+            if (Collection.class.isAssignableFrom(obj.getClass()) && !((Collection<?>) obj).isEmpty()) {
+                return isDBObjectLoaded((DBObject) ((Collection<?>) obj).iterator().next());
+            } else {
+                return isDBObjectLoaded((DBObject) obj);
+            }
+        }
+        return false;
+    }
+
+    private static boolean isDBObjectLoaded(DBObject dbObject) {
+        int counter = 0;
+        if (dbObject.containsField("_id")) {
+            counter++;
+        }
+        if (dbObject.containsField(RelMongoConstants.RELMONGOTARGET_PROPERTY_NAME)) {
+            counter++;
+        }
+        return dbObject.keySet().size() > counter;
     }
-    
-    
+
     public static ObjectId mapIdentifier(Object object) {
         return ((BasicDBObject) object).getObjectId("_id");
     }

src/test/java/io/github/kaiso/relmongo/data/model/Person.java

@@ -27,7 +27,7 @@ public class Person {
     private List<House> houses = new ArrayList<>();
 
     @OneToOne(fetch = FetchType.EAGER)
-    @JoinProperty(name = "passportref")
+    @JoinProperty(name = "passport")
     private Passport passport;
 
     @OneToOne(fetch = FetchType.LAZY, cascade = CascadeType.PERSIST)

src/test/java/io/github/kaiso/relmongo/tests/PersonRepositoryTest.java

@@ -114,13 +114,12 @@ public void shouldPersistOnlyReferencedPropertyOnOneToOneRelation() {
         person.setPassport(passport);
         repository.save(person);
         DBObject personNoRelational = mongoOperations.getCollection("people").find().next();
-        assertNull(personNoRelational.get("passport"));
         System.out.println("db id" + personNoRelational.get("passportId"));
         System.out.println("relational id" + passport.getId());
         BasicDBObject obj = new BasicDBObject();
         obj.put("_id", passport.getId());
         obj.put(RelMongoConstants.RELMONGOTARGET_PROPERTY_NAME, "passport");
-        assertEquals(personNoRelational.get("passportref"), obj);
+        assertEquals(personNoRelational.get("passport"), obj);
     }
 
     @Test