Switch path.walk to os.walk for py311

- Enables use of `finds_bids_datasets` in py311.
  - `root` in `_indexing.py` is initially passed as original type, with walked `dirpath` typecasted as Path
- Removed error for <py312 in throughout codebase + testing

Author: kaitj

bids2table/__main__.py

@@ -152,10 +152,6 @@ def _index_command(args: argparse.Namespace):
 
 
 def _find_command(args: argparse.Namespace):
-    if sys.version_info < (3, 12):
-        _logger.error("bids2table find requires Python 3.12 or higher.")
-        sys.exit(1)
-
     _check_path(args.root)
 
     for dataset in b2t2.find_bids_datasets(

bids2table/_indexing.py

@@ -7,8 +7,8 @@
 import enum
 import fnmatch
 import importlib.metadata
+import os
 import re
-import sys
 from concurrent.futures import Executor, ProcessPoolExecutor
 from functools import partial
 from typing import Any, Callable, Generator, Iterable, Sequence
@@ -143,21 +143,13 @@ def find_bids_datasets(
 
     Yields:
         Root paths of all BIDS datasets under `root`.
-
-    .. note::
-        Requires Python >= 3.12.
     """
-    if sys.version_info < (3, 12):
-        raise RuntimeError("find_bids_datasets requires Python 3.12 or higher.")
-
-    root = as_path(root)
-
     dir_count = 0
     ds_count = 0
 
-    # NOTE: Path.walk was introduced in 3.12. Otherwise, could use an older python.
-    for dirpath, dirnames, _ in root.walk(follow_symlinks=follow_symlinks):
+    for dirpath, dirnames, _ in os.walk(root, followlinks=follow_symlinks):
         dir_count += 1
+        dirpath = as_path(dirpath)
 
         if _is_bids_dataset(dirpath):
             ds_count += 1

tests/test_indexing.py

@@ -1,5 +1,4 @@
 import logging
-import sys
 from pathlib import Path
 
 import pyarrow as pa
@@ -25,7 +24,6 @@ def test_get_column_names():
     assert BIDSColumn.dataset == "dataset"
 
 
-@pytest.mark.skipif(sys.version_info < (3, 12), reason="Python < 3.12.")
 def test_find_bids_datasets():
     datasets = sorted(indexing.find_bids_datasets(BIDS_EXAMPLES, log_frequency=100))
     expected_datasets = sorted(

tests/test_main.py

@@ -43,7 +43,6 @@ def test_main_index(cmd: str, output: str | None, tmp_path: Path):
         assert (tmp_path / output).exists()
 
 
-@pytest.mark.skipif(sys.version_info < (3, 12), reason="Python < 3.12.")
 @pytest.mark.parametrize("cmd", ["find {examples}"])
 def test_main_find(cmd: str):
     cmd_fmt = cmd.format(examples=BIDS_EXAMPLES)