Commit a1f0340
committed
fix: make HuggingFace token optional for non-gated models
Only set spec.secrets.huggingFaceToken on ModelDeployment CRs when the
model is gated. Previously, the Web UI hardcoded hfTokenSecret for all
deployments, causing non-gated models (Qwen, DeepSeek, TinyLlama, Phi-3)
to fail with CreateContainerConfigError when the referenced K8s Secret
did not exist.
Changes:
- Conditional hfTokenSecret default based on model.gated
- Guard in handleSubmit to strip secret for non-gated models
- Remove KAITO exception from needsHfAuth button disable logic
- Add clarifying comments to sample YAMLs
Fixes #431 parent aff3083 commit a1f0340
3 files changed
Lines changed: 12 additions & 3 deletions
File tree
- controller/config/samples
- frontend/src/components/deployments
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
| |||
77 | 78 | | |
78 | 79 | | |
79 | 80 | | |
| 81 | + | |
80 | 82 | | |
81 | 83 | | |
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
| |||
54 | 55 | | |
55 | 56 | | |
56 | 57 | | |
| 58 | + | |
57 | 59 | | |
58 | 60 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
248 | 248 | | |
249 | 249 | | |
250 | 250 | | |
251 | | - | |
| 251 | + | |
252 | 252 | | |
253 | 253 | | |
254 | 254 | | |
| |||
370 | 370 | | |
371 | 371 | | |
372 | 372 | | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
373 | 378 | | |
374 | 379 | | |
375 | 380 | | |
| |||
592 | 597 | | |
593 | 598 | | |
594 | 599 | | |
595 | | - | |
| 600 | + | |
596 | 601 | | |
597 | 602 | | |
598 | 603 | | |
| |||
1558 | 1563 | | |
1559 | 1564 | | |
1560 | 1565 | | |
1561 | | - | |
| 1566 | + | |
1562 | 1567 | | |
1563 | 1568 | | |
1564 | 1569 | | |
| |||
0 commit comments