Skip to content

Commit a3a08be

Browse files
committed
fix: remove dead-code RBAC comments for namespace/CRD delete
deleteNamespace() and deleteCRD() in kubernetes.ts are dead code — never called by any route. Provider uninstall uses Helm CLI. Only HF token secret delete remains as a commented-out REVIEW item.
1 parent 5465e90 commit a3a08be

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

deploy/kubernetes/dashboard.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,10 @@ rules:
5151
verbs: ["list", "watch"]
5252

5353
# Namespaces (read + create)
54-
# REVIEW: Uncomment "delete" to enable provider uninstall features
5554
- apiGroups: [""]
5655
resources:
5756
- namespaces
5857
verbs: ["get", "list", "watch", "create"]
59-
# verbs: ["get", "list", "watch", "create", "delete"]
6058

6159
# Apps API - Deployments, ReplicaSets
6260
- apiGroups: ["apps"]
@@ -79,12 +77,10 @@ rules:
7977
verbs: ["get", "list", "watch", "delete"]
8078

8179
# CRD management (needed for provider detection)
82-
# REVIEW: Uncomment "delete" to enable provider uninstall features
8380
- apiGroups: ["apiextensions.k8s.io"]
8481
resources:
8582
- customresourcedefinitions
8683
verbs: ["get", "list"]
87-
# verbs: ["get", "list", "delete"]
8884

8985
# NVIDIA Dynamo CRDs
9086
- apiGroups: ["nvidia.com"]

0 commit comments

Comments
 (0)