Refactor Dockerfile for improved build stages and update health check endpoint. Add NODE_ENV to server for environment awareness and modify health check response to include environment status.

Author: kalayciburak

Dockerfile

@@ -1,46 +1,29 @@
-# Build Stage - Frontend
 FROM node:20 AS frontend-builder
 WORKDIR /app
 
-# Copy root package.json for workspace support
 COPY package*.json ./
-# Copy client package.json
 COPY client/package*.json ./client/
-# Copy server package.json
 COPY server/package*.json ./server/
 
-# Install all dependencies (workspaces will be hoisted)
 RUN npm ci
-
-# Copy client source code
 COPY client/ ./client/
 
-# Build frontend (generic - no environment variables)
 RUN npm run build -w client
 
-# Build Stage - Backend
 FROM node:20 AS backend-builder
 WORKDIR /app
 
-# Copy root package.json for workspace support
 COPY package*.json ./
-# Copy server package.json
 COPY server/package*.json ./server/
 
-# Install only production dependencies
 RUN npm ci --omit=dev
-
-# Copy server source code
 COPY server/ ./server/
 
-# Final Stage
 FROM node:20-slim
 WORKDIR /app
 
-# Copy built frontend
 COPY --from=frontend-builder /app/client/dist ./dist
 
-# Copy server files
 COPY --from=backend-builder /app/server ./server
 COPY --from=backend-builder /app/node_modules ./node_modules
 COPY --from=backend-builder /app/package*.json ./
@@ -52,8 +35,8 @@ ENV PORT=5000
 
 EXPOSE 5000
 
-HEALTHCHECK --interval=30s --timeout=3s --start-period=5s --retries=3 \
-  CMD node -e "require('http').get('http://localhost:5000/api/health', (r) => {process.exit(r.statusCode === 200 ? 0 : 1)})"
+HEALTHCHECK --interval=30s --timeout=3s --start-period=10s --retries=3 \
+  CMD node -e "require('http').get('http://localhost:' + (process.env.PORT || 5000) + '/healthz', (r) => {process.exit(r.statusCode === 200 ? 0 : 1)})"
 
 CMD ["node", "index.js"]
 

package-lock.json

@@ -11,6 +11,7 @@ dotenv.config();
 
 const app = express();
 const PORT = process.env.PORT || 5000;
+const NODE_ENV = process.env.NODE_ENV || "production";
 
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = path.dirname(__filename);
@@ -21,8 +22,12 @@ app.use(express.json());
 app.use("/api/auth", authRoutes);
 app.use("/api/coolify", coolifyRoutes);
 
-app.get("/api/health", (req, res) => {
-  res.json({ status: "ok", message: "Server is running" });
+app.get("/healthz", (req, res) => {
+  res.json({
+    status: "ok",
+    message: "Server is running",
+    ...(NODE_ENV !== "production" && { environment: NODE_ENV }),
+  });
 });
 
 app.use(express.static(path.join(__dirname, "../dist")));
@@ -35,4 +40,9 @@ app.use((err, req, res, _next) => {
   handleError(err, res);
 });
 
-app.listen(PORT, () => {});
+app.listen(PORT, () => {
+  if (NODE_ENV !== "production") {
+    console.log(`Server running on http://localhost:${PORT}`);
+    console.log(`Environment: ${NODE_ENV}`);
+  }
+});