PHP named attributes are not taken into account

[guerinetn]

Subject	Details
Plugin	Php Inspections (EA Ultimate),
Language level	PHP 8.2

Current behaviour

If I use a named attributes for a function it's not understood.

If I write :

$token = uniqid(more_entropy: true)

EA raise the error : Please provide 'more_entropy' parameter in order to increase likelihood of uniqueness.

It would be nice, il named attributes are understood by EA because this feature helps a lot when you have a lots of optional parameter to a function.

[COil]

I confirm the bug.

[DannyvdSluijs]

Other methods have the same issues e.g. json_decode

And it seems to be a duplicate of:

• JSON encoding API usage Harden errors handling vs PHP 8 named parameters #1639
• [False positive] JSON_THROW_ON_ERROR is not recognized in named parameter call (PHP 8.0) #1725
• [false positive] json_decode inspection does not recognize name identifier for the flags argument #1807
• "JSON encoding API usage" inspection works wrong when using PHP 8 named arguments feature #1845

[DannyvdSluijs]

The cause seems to be in this line of code where the arguments length is being checked as greater or equal to 4

I guess if possible the arguments should be checked for the index flags and take that argument

[kalessil]

@ea-inspections-team: +1 request to address this at least in the mentioned inspections.

[ea-inspections-team]

Thank you for reporting @guerinetn.

Question for everyone: are uniqid and json_decode are the only functions which we need to consider for hot-fix release?

[guerinetn]

Hello @ea-inspections-team at the moment it's the only method with this issues.
Thanks for your reply

[Flexo013]

@ea-inspections-team Is there a reason this open PR #1815 has not been picked up yet to resolve this issue?

[Elnadrion]

@ea-inspections-team: +1 request to address this at least in the mentioned inspections.

+1

[DannyvdSluijs]

@kalessil I wanted to kindly check with you if this is something @ea-inspections-team is working on?

Perhaps some pointers could be given in order help me (or other people watching this issue) out in trying to create a PR addressing this issue?

[ea-inspections-team]

Thank you for your patience, everyone. We are working on fixes for the functions and inspections mentioned in this issue and will release Extended and Ultimate plugins after the fixes.

[ea-inspections-team]

We are still working on fixes for the issue and delaying the next releases for around week - v2024.2 for EA ultimate and v 5.1.0 for EA Extended. If no solution found today, we will proceed with the releases tomorrow.