Skip to content

False positive "Please consider taking advantage of JSON_THROW_ON_ERROR flag for this call options." when using a const for flags parameter #1961

@fietserwin

Description

@fietserwin
Subject Details
Plugin Php Inspections (EA Extended) 5.1.0
Language level all

Code example

`
const MY_SIMPLE_JSON_FLAGS = JSON_THROW_ON_ERROR;

const MY_JSON_FLAGS = JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE | JSON_THROW_ON_ERROR |
JSON_PRESERVE_ZERO_FRACTION;

const MY_JSON_LOG_FLAGS = MY_JSON_FLAGS | JSON_PRETTY_PRINT;

$log_message1 = json_encode([], MY_SIMPLE_JSON_FLAGS);
$log_message2 = json_encode([], MY_JSON_FLAGS);
$log_message3 = json_encode([], MY_JSON_LOG_FLAGS);
`

Current behaviour

Warning on all 3 json_encode() statements

Expected behaviour

No warnings (I assume that the actual values of constants can be used on analysis).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions