wip(feathers-import-export): Fix sonar issue : Promise-returning method provided where a void return was expected by extended/implemented type 'Writable'. #13

style(feathers-s3): fixed typo

Author: cnouguier

packages/feathers-import-export/src/import.js

@@ -19,12 +19,13 @@ class ServiceWriteStream extends Writable {
   async _write (chunk, encoding, next) {
     this.chunkCount++
     this.objectCount += Array.isArray(chunk) ? chunk.length : 1
-    if (this.data.transform) {
-      if (typeof this.data.transform === 'function') chunk = await this.transform(chunk, this.data)
-      else chunk = transform(chunk, this.data.transform)
+    const process = async () => {
+      if (this.data.transform) {
+        if (typeof this.data.transform === 'function') { chunk = await this.transform(chunk, this.data) } else { chunk = transform(chunk, this.data.transform) }
+      }
+      await this.data.service.create(chunk)
     }
-    await this.data.service.create(chunk)
-    next()
+    process().then(() => next()).catch(next)
   }
 }
 

packages/feathers-s3/src/server/service.js

@@ -7,8 +7,15 @@ import _ from 'lodash'
 import createDebug from 'debug'
 import { BadRequest } from '@feathersjs/errors'
 import {
-  S3Client, ListObjectsCommand, GetObjectCommand, PutObjectCommand, DeleteObjectCommand, DeleteObjectsCommand,
-  CreateMultipartUploadCommand, UploadPartCommand, CompleteMultipartUploadCommand
+  S3Client,
+  ListObjectsCommand,
+  GetObjectCommand,
+  PutObjectCommand,
+  DeleteObjectCommand,
+  DeleteObjectsCommand,
+  CreateMultipartUploadCommand,
+  UploadPartCommand,
+  CompleteMultipartUploadCommand
 } from '@aws-sdk/client-s3'
 import { getSignedUrl } from '@aws-sdk/s3-request-presigner'
 
@@ -179,7 +186,7 @@ export class Service {
   }
 
   async completeMultipartUpload (data, params) {
-    // check paylod
+    // check payload
     if (!data.id) throw new BadRequest('completeMultipartUpload: mising \'data.id\'')
     if (!data.uploadId && !data.UploadId) throw new BadRequest('completeMultipartUpload: missing \'data.[U|u]ploadId\'')
     if (!data.parts) throw new BadRequest('completeMultipartUpload: missing \'data.parts\'')