Skip to content

Commit 8b25bdb

Browse files
committed
fix last bugs
1 parent dcd8938 commit 8b25bdb

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

reporters/kamon-opentelemetry/src/main/resources/reference.conf

+2-2
Original file line numberDiff line numberDiff line change
@@ -81,13 +81,13 @@ kamon.modules {
8181
otel-trace-reporter {
8282
enabled = true
8383
name = "OpenTelemetry Trace Reporter"
84-
description = "Sends trace data to a OpenTelemetry server via gRPC/REST+json"
84+
description = "Sends trace data to a OpenTelemetry server via gRPC/HTTP+protobuf"
8585
factory = "kamon.otel.OpenTelemetryTraceReporter$Factory"
8686
}
8787
otel-metrics-reporter {
8888
enabled = true
8989
name = "OpenTelemetry Metrics Reporter"
90-
description = "Sends metrics data to a OpenTelemetry server via gRPC/REST+json"
90+
description = "Sends metrics data to a OpenTelemetry server via gRPC/HTTP+protobuf"
9191
factory = "kamon.otel.OpenTelemetryMetricsReporter$Factory"
9292
}
9393
}

reporters/kamon-opentelemetry/src/main/scala/kamon/otel/Services.scala

+4-4
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import io.opentelemetry.sdk.metrics.`export`.MetricExporter
2424
import io.opentelemetry.sdk.metrics.data.MetricData
2525
import io.opentelemetry.sdk.trace.`export`.SpanExporter
2626
import io.opentelemetry.sdk.trace.data.SpanData
27-
import kamon.otel.OpenTelemetryConfiguration.Component.Trace
27+
import kamon.otel.OpenTelemetryConfiguration.Component.{ Metrics, Trace }
2828
import org.slf4j.LoggerFactory
2929

3030
import java.io.Closeable
@@ -106,18 +106,18 @@ private[otel] object OtlpMetricsService {
106106
* @param config
107107
* @return
108108
*/
109-
def apply(config: Config): MetricsService = new OtlpMetricsService(OpenTelemetryConfiguration(config, Trace))
109+
def apply(config: Config): MetricsService = new OtlpMetricsService(OpenTelemetryConfiguration(config, Metrics))
110110
}
111111

112112
private[otel] class OtlpMetricsService(c: OpenTelemetryConfiguration) extends MetricsService {
113113
private val compressionMethod = if (c.compressionEnabled) "gzip" else "none"
114114
private val delegate: MetricExporter = c.protocol match {
115115
case "grpc" =>
116-
val builder = OtlpHttpMetricExporter.builder().setEndpoint(c.endpoint).setCompression(compressionMethod).setTimeout(c.timeout)
116+
val builder = OtlpGrpcMetricExporter.builder().setEndpoint(c.endpoint).setCompression(compressionMethod).setTimeout(c.timeout)
117117
c.headers.foreach { case (k, v) => builder.addHeader(k, v) }
118118
builder.build()
119119
case "http/protobuf" =>
120-
val builder = OtlpGrpcMetricExporter.builder().setEndpoint(c.endpoint).setCompression(compressionMethod).setTimeout(c.timeout)
120+
val builder = OtlpHttpMetricExporter.builder().setEndpoint(c.endpoint).setCompression(compressionMethod).setTimeout(c.timeout)
121121
c.headers.foreach { case (k, v) => builder.addHeader(k, v) }
122122
builder.build()
123123
}

0 commit comments

Comments
 (0)