Skip to content

Commit b7904d9

Browse files
authored
Fix the build (#1344)
* fix scalaVersions for apache-cxf * fix compilation on scala 2.11 * rm an intermediate collection
1 parent bdf963e commit b7904d9

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

build.sbt

-1
Original file line numberDiff line numberDiff line change
@@ -845,7 +845,6 @@ lazy val `kamon-apache-cxf` = (project in file("instrumentation/kamon-apache-cxf
845845
.enablePlugins(JavaAgent)
846846
.settings(instrumentationSettings)
847847
.settings(
848-
crossScalaVersions := Seq(`scala_2.13_version`, `scala_3_version`),
849848
libraryDependencies ++= Seq(
850849
kanelaAgent % "provided",
851850
"org.apache.cxf" % "cxf-rt-frontend-simple" % "3.3.6" % "provided",

instrumentation/kamon-apache-cxf/src/main/scala/kamon/instrumentation/apache/cxf/client/ApacheCxfClientHelper.scala

+5-5
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ import org.slf4j.LoggerFactory
88
import java.net.{URI, URISyntaxException}
99
import java.util.Collections.{emptyMap => jEmptyMap, singletonList => jList}
1010
import java.util.{List => JList, Map => JMap}
11-
import scala.collection.mutable
12-
import scala.jdk.CollectionConverters.{ListHasAsScala, MapHasAsJava, MapHasAsScala}
11+
import scala.collection.JavaConverters._
1312

1413
class ApacheCxfClientHelper
1514

@@ -25,9 +24,10 @@ object ApacheCxfClientHelper {
2524
val uri: URI = getUri(request)
2625

2726
override def write(header: String, value: String): Unit = {
28-
val headers: mutable.Map[String, String] = getAllHeaders(delegate).to(mutable.Map)
29-
headers.put(header, value)
30-
delegate.put(Message.PROTOCOL_HEADERS, headers.map(m => m._1 -> jList(m._2)).toMap.asJava)
27+
val builder = Map.newBuilder[String, JList[String]]
28+
builder ++= getAllHeaders(delegate).map(m => m._1 -> jList(m._2))
29+
builder += header -> jList(value)
30+
delegate.put(Message.PROTOCOL_HEADERS, builder.result().asJava)
3131
}
3232

3333
override def build(): Message = {

instrumentation/kamon-apache-cxf/src/test/scala/kamon/instrumentation/apache/cxf/client/util/MockServerExpectations.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import org.mockserver.model.HttpRequest.request
88
import org.mockserver.model.HttpResponse.response
99
import org.slf4j.LoggerFactory
1010

11-
import scala.jdk.CollectionConverters.SeqHasAsJava
11+
import scala.collection.JavaConverters._
1212

1313
class MockServerExpectations(private val host: String, private val port: Int) {
1414

0 commit comments

Comments
 (0)