Skip to content

Commit dab289b

Browse files
authored
Merge pull request #988 from pnerg/w3c-parent-propagation
fix for w3c propagation of the proper parentSpanId (#986)
2 parents 03ca123 + 4421141 commit dab289b

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

core/kamon-core-tests/src/test/scala/kamon/trace/W3CTraceContextSpanPropagationSpec.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ class W3CTraceContextSpanPropagationSpec extends WordSpecLike with Matchers with
1414
val headersMap = mutable.Map.empty[String, String]
1515
traceContextPropagation.write(testContext(), headerWriterFromMap(headersMap))
1616

17-
headersMap.get("traceparent").value shouldBe "00-00000000000000000000000001020304-0000000004030201-01"
17+
headersMap.get("traceparent").value shouldBe "00-00000000000000000000000001020304-0000000002020202-01"
1818
headersMap.get("tracestate").value shouldBe ""
1919
}
2020

core/kamon-core/src/main/scala/kamon/trace/SpanPropagation.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ object W3CTraceContext {
107107

108108
val samplingDecision = if (parent.trace.samplingDecision == SamplingDecision.Sample) "01" else "00"
109109

110-
s"$Version-${idToHex(parent.trace.id, 32)}-${idToHex(parent.id, 16)}-${samplingDecision}"
110+
s"$Version-${idToHex(parent.trace.id, 32)}-${idToHex(parent.parentId, 16)}-${samplingDecision}"
111111
}
112112
}
113113

0 commit comments

Comments
 (0)