Commit 33f3b12
committed
Fix sendMessage race condition and test expectations.
1. Remove requestDrainComplete check from sendMessage to prevent out-of-order message delivery when app calls sendMessage concurrently with drain completion. Now we only bypass queue when passThroughMode is true.
2. Update givenExtProcStreamCompleted_whenIsReadyCalled_thenDelegatesToSuper test to expect the correct number of downstream isReady calls, which increased by 1 because we now correctly query isReady inside onReadyNotify on stream completion.
TAG=agy
CONV=2c1e4760-c239-4698-810a-162bf10fccc41 parent c9e02fa commit 33f3b12
2 files changed
Lines changed: 5 additions & 4 deletions
File tree
- xds/src
- main/java/io/grpc/xds
- test/java/io/grpc/xds
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
849 | 849 | | |
850 | 850 | | |
851 | 851 | | |
852 | | - | |
| 852 | + | |
853 | 853 | | |
854 | 854 | | |
855 | 855 | | |
856 | 856 | | |
857 | 857 | | |
858 | | - | |
| 858 | + | |
859 | 859 | | |
860 | 860 | | |
861 | 861 | | |
| |||
1394 | 1394 | | |
1395 | 1395 | | |
1396 | 1396 | | |
| 1397 | + | |
1397 | 1398 | | |
1398 | 1399 | | |
1399 | 1400 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6070 | 6070 | | |
6071 | 6071 | | |
6072 | 6072 | | |
6073 | | - | |
| 6073 | + | |
6074 | 6074 | | |
6075 | 6075 | | |
6076 | 6076 | | |
6077 | | - | |
| 6077 | + | |
6078 | 6078 | | |
6079 | 6079 | | |
6080 | 6080 | | |
| |||
0 commit comments