more tests

abtomer · abtomer · commit fd8d6e1dc120 · 2025-11-13T13:53:23.000+02:00
diff --git a/resources/scala-3/implicit-default-added.scala_test b/resources/scala-3/implicit-default-added.scala_test
@@ -0,0 +1,8 @@
+import upickle.default.{ReadWriter, Pickler}
+
+final case class ImplicitAccount(
+  id: Int,
+  plan: String = "basic"
+)
+
+implicit val implicitAccountRW: ReadWriter[ImplicitAccount] = Pickler.macroRW
diff --git a/resources/scala-3/implicit-default-added.scala_test.prev b/resources/scala-3/implicit-default-added.scala_test.prev
@@ -0,0 +1,8 @@
+import upickle.default.{ReadWriter, Pickler}
+
+final case class ImplicitAccount(
+  id: Int,
+  plan: String
+)
+
+implicit val implicitAccountRW: ReadWriter[ImplicitAccount] = Pickler.macroRW
diff --git a/resources/scala-3/implicit-default-removed.scala_test b/resources/scala-3/implicit-default-removed.scala_test
@@ -0,0 +1,8 @@
+import upickle.default.{ReadWriter, Pickler}
+
+final case class ImplicitSettings(
+  id: Int,
+  theme: String
+)
+
+implicit val implicitSettingsRW: ReadWriter[ImplicitSettings] = Pickler.macroRW
diff --git a/resources/scala-3/implicit-default-removed.scala_test.prev b/resources/scala-3/implicit-default-removed.scala_test.prev
@@ -0,0 +1,8 @@
+import upickle.default.{ReadWriter, Pickler}
+
+final case class ImplicitSettings(
+  id: Int,
+  theme: String = "dark"
+)
+
+implicit val implicitSettingsRW: ReadWriter[ImplicitSettings] = Pickler.macroRW
diff --git a/resources/scala-3/implicit-non-breaking-change.scala_test b/resources/scala-3/implicit-non-breaking-change.scala_test
@@ -0,0 +1,9 @@
+import upickle.default.{ReadWriter, Pickler}
+
+final case class ImplicitUser(
+  id: Int,
+  name: String,
+  role: String = "user"
+)
+
+implicit val implicitUserRW: ReadWriter[ImplicitUser] = Pickler.macroRW
diff --git a/resources/scala-3/implicit-non-breaking-change.scala_test.prev b/resources/scala-3/implicit-non-breaking-change.scala_test.prev
@@ -0,0 +1,8 @@
+import upickle.default.{ReadWriter, Pickler}
+
+final case class ImplicitUser(
+  id: Int,
+  name: String
+)
+
+implicit val implicitUserRW: ReadWriter[ImplicitUser] = Pickler.macroRW
diff --git a/resources/scala-3/implicit-removed-field.scala_test b/resources/scala-3/implicit-removed-field.scala_test
@@ -0,0 +1,8 @@
+import upickle.default.{ReadWriter, Pickler}
+
+final case class ImplicitContact(
+  id: Int,
+  name: String
+)
+
+implicit val implicitContactRW: ReadWriter[ImplicitContact] = Pickler.macroRW
diff --git a/resources/scala-3/implicit-removed-field.scala_test.prev b/resources/scala-3/implicit-removed-field.scala_test.prev
@@ -0,0 +1,9 @@
+import upickle.default.{ReadWriter, Pickler}
+
+final case class ImplicitContact(
+  id: Int,
+  name: String,
+  email: String
+)
+
+implicit val implicitContactRW: ReadWriter[ImplicitContact] = Pickler.macroRW
diff --git a/resources/scala-3/implicit-serialization-added.scala_test b/resources/scala-3/implicit-serialization-added.scala_test
@@ -0,0 +1,8 @@
+import upickle.default.{ReadWriter, Pickler}
+
+final case class ImplicitProfile(
+  id: Int,
+  name: String
+)
+
+implicit val implicitProfileRW: ReadWriter[ImplicitProfile] = Pickler.macroRW
diff --git a/resources/scala-3/implicit-serialization-added.scala_test.prev b/resources/scala-3/implicit-serialization-added.scala_test.prev
@@ -0,0 +1,4 @@
+final case class ImplicitProfile(
+  id: Int,
+  name: String
+)
diff --git a/resources/scala-3/implicit-serialization-type-change.scala_test b/resources/scala-3/implicit-serialization-type-change.scala_test
@@ -0,0 +1,8 @@
+import upickle.default.{Writer, Pickler}
+
+final case class ImplicitOrder(
+  id: String,
+  total: BigDecimal
+)
+
+implicit val implicitOrderWriter: upickle.default.Writer[ImplicitOrder] = Pickler.macroW
diff --git a/resources/scala-3/implicit-serialization-type-change.scala_test.prev b/resources/scala-3/implicit-serialization-type-change.scala_test.prev
@@ -0,0 +1,8 @@
+import upickle.default.{ReadWriter, Pickler}
+
+final case class ImplicitOrder(
+  id: String,
+  total: BigDecimal
+)
+
+implicit val implicitOrderRW: ReadWriter[ImplicitOrder] = Pickler.macroRW
diff --git a/test/BreakingChangeDetector.test.scala b/test/BreakingChangeDetector.test.scala
@@ -279,4 +279,147 @@ class BreakingChangeDetectorTest extends munit.FunSuite {
     val breakingChange = compared.find(_.isBreakingChange).get
     assert(breakingChange.addedFieldsWithoutDefaultValues.contains("email"))
   }
+
+  test("Implicit serialization - adding a field with a default value is not breaking") {
+    val oldFile = Thread
+      .currentThread()
+      .getContextClassLoader
+      .getResource("scala-3/implicit-non-breaking-change.scala_test.prev")
+      .getPath
+    val oldFileParsed = FileParser.fromPathToClassDef(oldFile)
+    val newFile = Thread
+      .currentThread()
+      .getContextClassLoader
+      .getResource("scala-3/implicit-non-breaking-change.scala_test")
+      .getPath
+    val newFileParsed = FileParser.fromPathToClassDef(newFile)
+    val compared =
+      BreakingChangeDetector.detectBreakingChange(oldFileParsed, newFileParsed)
+    println(compared)
+    assert(
+      compared.find(_.isBreakingChange).isEmpty
+    )
+  }
+
+  test("Implicit serialization - removing a field is a breaking change") {
+    val oldFile = Thread
+      .currentThread()
+      .getContextClassLoader
+      .getResource("scala-3/implicit-removed-field.scala_test.prev")
+      .getPath
+    val oldFileParsed = FileParser.fromPathToClassDef(oldFile)
+    val newFile = Thread
+      .currentThread()
+      .getContextClassLoader
+      .getResource("scala-3/implicit-removed-field.scala_test")
+      .getPath
+    val newFileParsed = FileParser.fromPathToClassDef(newFile)
+    val compared =
+      BreakingChangeDetector.detectBreakingChange(oldFileParsed, newFileParsed)
+    println(compared)
+    assert(
+      compared.find(_.isBreakingChange).nonEmpty
+    )
+    val breakingChange = compared.find(_.isBreakingChange).get
+    assert(breakingChange.removedFields.contains("email"))
+  }
+
+  test("Implicit serialization - adding implicit instance is not breaking change") {
+    val oldFile = Thread
+      .currentThread()
+      .getContextClassLoader
+      .getResource("scala-3/implicit-serialization-added.scala_test.prev")
+      .getPath
+    val oldFileParsed = FileParser.fromPathToClassDef(oldFile)
+    val newFile = Thread
+      .currentThread()
+      .getContextClassLoader
+      .getResource("scala-3/implicit-serialization-added.scala_test")
+      .getPath
+    val newFileParsed = FileParser.fromPathToClassDef(newFile)
+    val compared =
+      BreakingChangeDetector.detectBreakingChange(oldFileParsed, newFileParsed)
+    println(compared)
+    assert(
+      compared.find(_.isBreakingChange).isEmpty
+    )
+  }
+
+  test("Implicit serialization - removing default value is a breaking change") {
+    val oldFile = Thread
+      .currentThread()
+      .getContextClassLoader
+      .getResource("scala-3/implicit-default-removed.scala_test.prev")
+      .getPath
+    val oldFileParsed = FileParser.fromPathToClassDef(oldFile)
+    val newFile = Thread
+      .currentThread()
+      .getContextClassLoader
+      .getResource("scala-3/implicit-default-removed.scala_test")
+      .getPath
+    val newFileParsed = FileParser.fromPathToClassDef(newFile)
+    val compared =
+      BreakingChangeDetector.detectBreakingChange(oldFileParsed, newFileParsed)
+    println(compared)
+    assert(
+      compared.find(_.isBreakingChange).nonEmpty
+    )
+    val breakingChange = compared.find(_.isBreakingChange).get
+    assert(breakingChange.fieldsWithDefaultValuesThatWasRemoved.contains("theme"))
+  }
+
+  test("Implicit serialization - adding default value is a breaking change") {
+    val oldFile = Thread
+      .currentThread()
+      .getContextClassLoader
+      .getResource("scala-3/implicit-default-added.scala_test.prev")
+      .getPath
+    val oldFileParsed = FileParser.fromPathToClassDef(oldFile)
+    val newFile = Thread
+      .currentThread()
+      .getContextClassLoader
+      .getResource("scala-3/implicit-default-added.scala_test")
+      .getPath
+    val newFileParsed = FileParser.fromPathToClassDef(newFile)
+    val compared =
+      BreakingChangeDetector.detectBreakingChange(oldFileParsed, newFileParsed)
+    println(compared)
+    assert(
+      compared.find(_.isBreakingChange).nonEmpty
+    )
+    val breakingChange = compared.find(_.isBreakingChange).get
+    assert(breakingChange.fieldsThatDefaultValueWasAddedToThem.contains("plan"))
+  }
+
+  test("Implicit serialization - changing serialization type is a breaking change") {
+    def runWithFiles(oldFileName: String, newFileName: String) = {
+      val oldFile = Thread
+        .currentThread()
+        .getContextClassLoader
+        .getResource(oldFileName)
+        .getPath
+      val oldFileParsed = FileParser.fromPathToClassDef(oldFile)
+      val newFile = Thread
+        .currentThread()
+        .getContextClassLoader
+        .getResource(newFileName)
+        .getPath
+      val newFileParsed = FileParser.fromPathToClassDef(newFile)
+      val compared =
+        BreakingChangeDetector.detectBreakingChange(oldFileParsed, newFileParsed)
+      println(compared)
+      assert(
+        compared.find(_.isBreakingChange).nonEmpty
+      )
+    }
+
+    runWithFiles(
+      "scala-3/implicit-serialization-type-change.scala_test.prev",
+      "scala-3/implicit-serialization-type-change.scala_test"
+    )
+    runWithFiles(
+      "scala-3/implicit-serialization-type-change.scala_test",
+      "scala-3/implicit-serialization-type-change.scala_test.prev"
+    )
+  }
 }
