Skip to content

Commit c4d12bb

Browse files
authored
[8.19] [js-yaml to yaml migration] @elastic/obs-onboarding-team (elastic#252349) (elastic#271838)
# Backport This will backport the following commits from `main` to `8.19`: - [[js-yaml to yaml migration] @elastic/obs-onboarding-team (elastic#252349)](elastic#252349) <!--- Backport version: 11.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Jeramy Soucy","email":"jeramy.soucy@elastic.co"},"sourceCommit":{"committedDate":"2026-05-29T06:58:39Z","message":"[js-yaml to yaml migration] @elastic/obs-onboarding-team (elastic#252349)\n\nCloses elastic#267871\n\n## Migration: js-yaml → yaml\n\nThis PR migrates 8 file(s) from `js-yaml` to `yaml` package for\n@elastic/obs-onboarding-team.\n\n### Changes\n- Replaced `js-yaml` imports with `yaml` package\n- Updated function calls: `load()` → `parse()`, `dump()` → `stringify()`\n- Mapped options:\n - `noRefs: true` → `aliasDuplicateObjects: false`\n - `skipInvalid: true` → `strict: false`\n - `sortKeys` → `sortMapEntries`\n - `JSON_SCHEMA` → `schema: 'core'`\n\n### Files Changed\n-\n`src/platform/packages/shared/kbn-otel-demo/src/demos/online_boutique/manifests.ts`\n-\n`src/platform/packages/shared/kbn-otel-demo/src/demos/otel_demo/manifests.ts`\n-\n`src/platform/packages/shared/kbn-otel-demo/src/get_kubernetes_manifests.ts`\n- `src/platform/packages/shared/kbn-otel-demo/src/read_kibana_config.ts`\n-\n`src/platform/packages/shared/kbn-otel-semantic-conventions/__tests__/generate_semconv.test.ts`\n-\n`src/platform/packages/shared/kbn-otel-semantic-conventions/src/lib/generate_semconv.ts`\n-\n`src/platform/packages/shared/kbn-otel-semantic-conventions/src/sort_yaml.ts`\n-\n`x-pack/solutions/observability/plugins/observability_onboarding/server/routes/flow/route.ts`\n\n### Testing\n- All relevant Jest tests pass\n- Snapshot tests updated to reflect new YAML output format\n\n---\n\n**Note:** This is part of a larger migration effort. Other teams' files\nare in separate PRs. These changes were generated using Cursor.","sha":"95273155871d61a1c674823af4f26ba4102a441e","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","backport:all-open","v9.5.0"],"title":"[js-yaml to yaml migration] @elastic/obs-onboarding-team","number":252349,"url":"https://github.com/elastic/kibana/pull/252349","mergeCommit":{"message":"[js-yaml to yaml migration] @elastic/obs-onboarding-team (elastic#252349)\n\nCloses elastic#267871\n\n## Migration: js-yaml → yaml\n\nThis PR migrates 8 file(s) from `js-yaml` to `yaml` package for\n@elastic/obs-onboarding-team.\n\n### Changes\n- Replaced `js-yaml` imports with `yaml` package\n- Updated function calls: `load()` → `parse()`, `dump()` → `stringify()`\n- Mapped options:\n - `noRefs: true` → `aliasDuplicateObjects: false`\n - `skipInvalid: true` → `strict: false`\n - `sortKeys` → `sortMapEntries`\n - `JSON_SCHEMA` → `schema: 'core'`\n\n### Files Changed\n-\n`src/platform/packages/shared/kbn-otel-demo/src/demos/online_boutique/manifests.ts`\n-\n`src/platform/packages/shared/kbn-otel-demo/src/demos/otel_demo/manifests.ts`\n-\n`src/platform/packages/shared/kbn-otel-demo/src/get_kubernetes_manifests.ts`\n- `src/platform/packages/shared/kbn-otel-demo/src/read_kibana_config.ts`\n-\n`src/platform/packages/shared/kbn-otel-semantic-conventions/__tests__/generate_semconv.test.ts`\n-\n`src/platform/packages/shared/kbn-otel-semantic-conventions/src/lib/generate_semconv.ts`\n-\n`src/platform/packages/shared/kbn-otel-semantic-conventions/src/sort_yaml.ts`\n-\n`x-pack/solutions/observability/plugins/observability_onboarding/server/routes/flow/route.ts`\n\n### Testing\n- All relevant Jest tests pass\n- Snapshot tests updated to reflect new YAML output format\n\n---\n\n**Note:** This is part of a larger migration effort. Other teams' files\nare in separate PRs. These changes were generated using Cursor.","sha":"95273155871d61a1c674823af4f26ba4102a441e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/252349","number":252349,"mergeCommit":{"message":"[js-yaml to yaml migration] @elastic/obs-onboarding-team (elastic#252349)\n\nCloses elastic#267871\n\n## Migration: js-yaml → yaml\n\nThis PR migrates 8 file(s) from `js-yaml` to `yaml` package for\n@elastic/obs-onboarding-team.\n\n### Changes\n- Replaced `js-yaml` imports with `yaml` package\n- Updated function calls: `load()` → `parse()`, `dump()` → `stringify()`\n- Mapped options:\n - `noRefs: true` → `aliasDuplicateObjects: false`\n - `skipInvalid: true` → `strict: false`\n - `sortKeys` → `sortMapEntries`\n - `JSON_SCHEMA` → `schema: 'core'`\n\n### Files Changed\n-\n`src/platform/packages/shared/kbn-otel-demo/src/demos/online_boutique/manifests.ts`\n-\n`src/platform/packages/shared/kbn-otel-demo/src/demos/otel_demo/manifests.ts`\n-\n`src/platform/packages/shared/kbn-otel-demo/src/get_kubernetes_manifests.ts`\n- `src/platform/packages/shared/kbn-otel-demo/src/read_kibana_config.ts`\n-\n`src/platform/packages/shared/kbn-otel-semantic-conventions/__tests__/generate_semconv.test.ts`\n-\n`src/platform/packages/shared/kbn-otel-semantic-conventions/src/lib/generate_semconv.ts`\n-\n`src/platform/packages/shared/kbn-otel-semantic-conventions/src/sort_yaml.ts`\n-\n`x-pack/solutions/observability/plugins/observability_onboarding/server/routes/flow/route.ts`\n\n### Testing\n- All relevant Jest tests pass\n- Snapshot tests updated to reflect new YAML output format\n\n---\n\n**Note:** This is part of a larger migration effort. Other teams' files\nare in separate PRs. These changes were generated using Cursor.","sha":"95273155871d61a1c674823af4f26ba4102a441e"}},{"url":"https://github.com/elastic/kibana/pull/271832","number":271832,"branch":"9.4","state":"OPEN"}]}] BACKPORT-->
1 parent bf0c411 commit c4d12bb

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

  • x-pack/solutions/observability/plugins/observability_onboarding/server/routes/flow

x-pack/solutions/observability/plugins/observability_onboarding/server/routes/flow/route.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {
1212
FleetUnauthorizedError,
1313
type PackageClient,
1414
} from '@kbn/fleet-plugin/server';
15-
import { dump } from 'js-yaml';
15+
import { stringify } from 'yaml';
1616
import { PackageDataStreamTypes, Output } from '@kbn/fleet-plugin/common/types';
1717
import { transformOutputToFullPolicyOutput } from '@kbn/fleet-plugin/server/services/output_client';
1818
import { OBSERVABILITY_ONBOARDING_TELEMETRY_EVENT } from '../../../common/telemetry_events';
@@ -431,7 +431,7 @@ async function ensureInstalledIntegrations(
431431
pkgName,
432432
pkgVersion: '1.0.0', // Custom integrations are always installed as version `1.0.0`
433433
title: pkgName,
434-
config: dump({
434+
config: stringify({
435435
inputs: [
436436
{
437437
id: `filestream-${pkgName}`,
@@ -561,7 +561,7 @@ function generateAgentConfigTar(output: Output, installedIntegrations: Installed
561561
path: 'elastic-agent.yml',
562562
mode: 0o644,
563563
mtime: now,
564-
data: dump({
564+
data: stringify({
565565
outputs: {
566566
default: transformOutputToFullPolicyOutput(output, undefined, true),
567567
},

0 commit comments

Comments
 (0)