Merge pull request #100 from pior/cleanups

Add a missing test and minor code cleanups

Author: karlseguin

cache.go

@@ -373,7 +373,6 @@ func (c *Cache[T]) gc() int {
 		if item == nil {
 			return dropped
 		}
-		// fmt.Println(item.key)
 		prev := item.prev
 		if !c.tracking || atomic.LoadInt32(&item.refCount) == 0 {
 			c.bucket(item.key).delete(item.key)

configuration.go

@@ -3,7 +3,6 @@ package ccache
 type Configuration[T any] struct {
 	maxSize        int64
 	buckets        int
-	itemsToPrune   int
 	percentToPrune int
 	deleteBuffer   int
 	promoteBuffer  int
@@ -18,7 +17,6 @@ type Configuration[T any] struct {
 func Configure[T any]() *Configuration[T] {
 	return &Configuration[T]{
 		buckets:        16,
-		itemsToPrune:   0,
 		percentToPrune: 10,
 		deleteBuffer:   1024,
 		getsPerPromote: 3,
@@ -99,7 +97,7 @@ func (c *Configuration[T]) Track() *Configuration[T] {
 	return c
 }
 
-// OnDelete allows setting a callback function to react to ideam deletion.
+// OnDelete allows setting a callback function to react to item deletion.
 // This typically allows to do a cleanup of resources, such as calling a Close() on
 // cached object that require some kind of tear-down.
 func (c *Configuration[T]) OnDelete(callback func(item *Item[T])) *Configuration[T] {

list_test.go

@@ -56,6 +56,34 @@ func Test_List_Remove(t *testing.T) {
 	assertList(t, l)
 }
 
+func Test_List_MoveToFront(t *testing.T) {
+	l := NewList[int]()
+
+	// Single item - already at front
+	n1 := newItem("a", 1, 0, false)
+	l.Insert(n1)
+	l.MoveToFront(n1)
+	assertList(t, l, 1)
+
+	// Head item - already at front
+	n2 := newItem("b", 2, 0, false)
+	l.Insert(n2)
+	assertList(t, l, 2, 1)
+	l.MoveToFront(n2)
+	assertList(t, l, 2, 1)
+
+	// Tail item
+	l.MoveToFront(n1)
+	assertList(t, l, 1, 2)
+
+	// Middle item
+	n3 := newItem("c", 3, 0, false)
+	l.Insert(n3)
+	assertList(t, l, 3, 1, 2)
+	l.MoveToFront(n1)
+	assertList(t, l, 1, 3, 2)
+}
+
 func assertList(t *testing.T, list *List[int], expected ...int) {
 	t.Helper()