Merge pull request #51 from BlueMonday/マッハGoGoGo

karlseguin · web-flow · commit d9f8808f13f9 · 2020-11-18T17:58:29.000+08:00
Fix race condition in Cache.Get()
diff --git a/cache.go b/cache.go
@@ -85,7 +85,7 @@ func (c *Cache) Get(key string) *Item {
 	if item == nil {
 		return nil
 	}
-	if item.expires > time.Now().UnixNano() {
+	if !item.Expired() {
 		c.promote(item)
 	}
 	return item

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ func (c Cache) Get(key string) Item {`
`85`	`85`	`if item == nil {`
`86`	`86`	`return nil`
`87`	`87`	`}`
`88`		`- if item.expires > time.Now().UnixNano() {`
	`88`	`+ if !item.Expired() {`
`89`	`89`	`c.promote(item)`
`90`	`90`	`}`
`91`	`91`	`return item`