Merge pull request #6297 from seanlaii/fix-QF1001

karmada-bot · web-flow · commit 4eb2d273ab53 · 2025-04-14T14:12:01.000+08:00
Fix lint issue QF1001
diff --git a/.golangci.yml b/.golangci.yml
@@ -72,7 +72,6 @@ linters:
         # Will fix the issues in the following PRs.
         # Issue: https://github.com/karmada-io/karmada/issues/6273.
         - "-ST1011"
-        - "-QF1001"
         - "-ST1000"
   exclusions:
     generated: lax
diff --git a/pkg/karmadactl/get/get.go b/pkg/karmadactl/get/get.go
@@ -250,7 +250,7 @@ func (g *CommandGetOptions) Validate(cmd *cobra.Command) error {
 			return fmt.Errorf("--show-labels option cannot be used with %s printer", outputOption)
 		}
 	}
-	if g.OutputWatchEvents && !(g.Watch || g.WatchOnly) {
+	if g.OutputWatchEvents && !g.Watch && !g.WatchOnly {
 		return fmt.Errorf("--output-watch-events option can only be used with --watch or --watch-only")
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -250,7 +250,7 @@ func (g CommandGetOptions) Validate(cmd cobra.Command) error {`
`250`	`250`	`return fmt.Errorf("--show-labels option cannot be used with %s printer", outputOption)`
`251`	`251`	`}`
`252`	`252`	`}`
`253`		`- if g.OutputWatchEvents && !(g.Watch \|\| g.WatchOnly) {`
	`253`	`+ if g.OutputWatchEvents && !g.Watch && !g.WatchOnly {`
`254`	`254`	`return fmt.Errorf("--output-watch-events option can only be used with --watch or --watch-only")`
`255`	`255`	`}`
`256`	`256`