Skip to content

Commit 9d68815

Browse files
authored
Merge pull request #6373 from XiShanYongYe-Chang/remove-noexecute-toleration
Deprecated default-not-ready-toleration-seconds and default-unreachable-toleration-seconds flags for karmada-webhook
2 parents e8ddbd7 + a5ffc84 commit 9d68815

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

cmd/webhook/app/options/options.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,9 @@ func (o *Options) AddFlags(flags *pflag.FlagSet) {
9595

9696
// webhook flags
9797
flags.Int64Var(&o.DefaultNotReadyTolerationSeconds, "default-not-ready-toleration-seconds", 300, "Indicates the tolerationSeconds of the propagation policy toleration for notReady:NoExecute that is added by default to every propagation policy that does not already have such a toleration.")
98+
_ = flags.MarkDeprecated("default-not-ready-toleration-seconds", "Karmada will no longer automatically add cluster.karmada.io/not-ready:NoExecute taint to cluster objects, so there is no need to add default tolerations in propagation policy, default-not-ready-toleration-seconds is deprecated and will be removed in v1.15.")
9899
flags.Int64Var(&o.DefaultUnreachableTolerationSeconds, "default-unreachable-toleration-seconds", 300, "Indicates the tolerationSeconds of the propagation policy toleration for unreachable:NoExecute that is added by default to every propagation policy that does not already have such a toleration.")
100+
_ = flags.MarkDeprecated("default-unreachable-toleration-seconds", "Karmada will no longer automatically add cluster.karmada.io/unreachable:NoExecute taint to cluster objects, so there is no need to add default tolerations in propagation policy, default-unreachable-toleration-seconds is deprecated and will be removed in v1.15.")
99101

100102
features.FeatureGate.AddFlag(flags)
101103
o.ProfileOpts.AddFlags(flags)

0 commit comments

Comments
 (0)