Skip to content

Commit ca6f17f

Browse files
authored
Merge pull request #5264 from zhzhuang-zju/SerialDescribe
fix unexpected interference between different e2e use cases
2 parents ff0b84d + 903648a commit ca6f17f

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

test/e2e/clusterpropagationpolicy_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -547,7 +547,8 @@ var _ = ginkgo.Describe("[AdvancedClusterPropagation] propagation testing", func
547547
})
548548

549549
// ImplicitPriority more than one PP matches the object, we should choose the most suitable one.
550-
var _ = ginkgo.Describe("[ImplicitPriority] propagation testing", func() {
550+
// Set it to run sequentially to avoid affecting other test cases.
551+
var _ = framework.SerialDescribe("[ImplicitPriority] propagation testing", func() {
551552
ginkgo.Context("priorityMatchName/priorityMatchLabel/priorityMatchAll propagation testing", func() {
552553
var priorityMatchName, priorityMatchLabelSelector, priorityMatchAll string
553554
var deploymentNamespace, deploymentName string

test/e2e/propagationpolicy_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -514,7 +514,8 @@ var _ = ginkgo.Describe("[BasicPropagation] propagation testing", func() {
514514
})
515515

516516
// ImplicitPriority more than one PP matches the object, we should choose the most suitable one.
517-
var _ = ginkgo.Describe("[ImplicitPriority] propagation testing", func() {
517+
// Set it to run sequentially to avoid affecting other test cases.
518+
var _ = framework.SerialDescribe("[ImplicitPriority] propagation testing", func() {
518519
ginkgo.Context("priorityMatchName propagation testing", func() {
519520
var policyNamespace, priorityMatchName, priorityMatchLabelSelector, priorityMatchAll string
520521
var deploymentNamespace, deploymentName string

0 commit comments

Comments
 (0)