-
Notifications
You must be signed in to change notification settings - Fork 1k
Description
What happened:
This is low-priority but thought I'd file an issue regardless. I noticed that the condition which is appended to the RB in cases of FRQ limits being exceeded is no longer using the QuotaExceeded reason, but rather using the generic SchedulerError. This feels incorrect since quota being exceeded isn't a scheduler error.
This was changed during a refactor of the RB validation webhook: https://github.com/karmada-io/karmada/pull/6611/files#diff-b8020421c760e9ea07cb49bd49e3604078f0351faaa7f60e3b13e7f372ea73adL326
We can either fix the validating webhook to append this custom error reason, or change the way the error is handled in the scheduler to parse the error message, instead of checking for the QuotaExceeded reason.
What you expected to happen:
Condition should be appended with the correct reason. Example:
status:
conditions:
- lastTransitionTime: "2026-01-02T19:35:30Z"
message: 'admission webhook "resourcebinding.karmada.io" denied the request: FederatedResourceQuota(s-spaaseng/federated-quota)
exceeded for resource cpu: requested sum 32500m, limit 30.'
reason: QuotaExceeded
status: "False"
type: ScheduledEnvironment:
- Karmada version: 1.16
Metadata
Metadata
Assignees
Labels
Type
Projects
Status