-
Notifications
You must be signed in to change notification settings - Fork 165
[Umbrella] Unify line endings to LF & add CRLF check workflow #1026
Copy link
Copy link
Open
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.
Description
Metadata
Metadata
Assignees
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.
Type
Fields
Give feedbackNo fields configured for issues without a type.
What would you like to be added:
CRLFtoLFto unify file formats.CRLFline endings in pull requests to prevent regression.The command
git grep --cached -I $'\r'can be used to check for carriage returns in committed text files.Tasks:
Why is this needed:
Some documents in the karmada-website repo use
CRLFline endings instead ofLF.CRLFmay trigger unexpected behaviors of thecherrypickerplugin when backporting changes between branches. see [cherrypicker]: reports a false conflict although the change applies cleanly kubernetes-sigs/prow#745