Merge pull request #6 from karriereat/feature/process-timeout-flag

Add parameter "ptimeout"

Author: Munsio

src/CodeCoverage.php

@@ -26,6 +26,7 @@ public static function run(Event $event)
 
         $process = new Process($command);
         $process->setTtyByArguments($eventArguments);
+        $process->setProcessTimeoutByArguments($eventArguments);
         $process->run();
 
         return $process->getExitCode();

src/CodeStyleChecker.php

@@ -32,6 +32,7 @@ public static function run(Event $event)
 
         $process = new Process($command);
         $process->setTtyByArguments($eventArguments);
+        $process->setProcessTimeoutByArguments($eventArguments);
         $process->run();
 
         $composerIO->write($process->getOutput());

src/CodeStyleFixer.php

@@ -27,6 +27,7 @@ public static function run(Event $event)
 
         $process = new Process(self::$command);
         $process->setTtyByArguments($eventArguments);
+        $process->setProcessTimeoutByArguments($eventArguments);
         $process->run();
 
         $composerIO->write($process->getOutput());

src/MessDetector.php

@@ -26,6 +26,7 @@ public static function run(Event $event)
 
         $process = new Process($command);
         $process->setTtyByArguments($eventArguments);
+        $process->setProcessTimeoutByArguments($eventArguments);
         $process->run();
 
         return $process->getExitCode();

src/Process/Process.php

@@ -17,6 +17,13 @@ class Process extends SymfonyProcess
      */
     const NO_TTY_FLAG = 'notty';
 
+    /**
+     * Flag to set the symfony process timeout as parameter.
+     *
+     * @var string
+     */
+    const PROCESS_TIMEOUT = 'ptimeout';
+
     public function __construct($commandline)
     {
         parent::__construct($commandline);
@@ -25,7 +32,7 @@ public function __construct($commandline)
     /**
      * Check if the process was started with a 'notty' flag, if yes, deactivate it.
      *
-     * @param $eventArguments
+     * @param array $eventArguments
      * @return bool
      */
     public function setTtyByArguments($eventArguments)
@@ -44,4 +51,19 @@ public function setTtyByArguments($eventArguments)
 
         return true;
     }
+
+    /**
+     * Check if the process was started with a 'ptimeout' flag, if not, use default 60s timeout
+     *
+     * @param array $eventArguments
+     * @return bool
+     */
+    public function setProcessTimeoutByArguments($eventArguments)
+    {
+        if (self::hasParameterOption(self::PROCESS_TIMEOUT, $eventArguments)) {
+            $this->setTimeout($eventArguments[self::PROCESS_TIMEOUT]);
+        }
+
+        return true;
+    }
 }

src/SpecificationTest.php

@@ -32,6 +32,7 @@ public static function run(Event $event)
 
         $process = new Process($command);
         $process->setTtyByArguments($eventArguments);
+        $process->setProcessTimeoutByArguments($eventArguments);
         $process->run();
 
         $composerIO->write($process->getOutput());

tests/specs/Process/ProcessSpec.php

@@ -38,4 +38,11 @@ function its_tty_mode_can_be_set()
             // Testing for `true` or `false` doesn't make sense, so we skip this test.
         }
     }
+
+    function its_process_timeout_can_be_set()
+    {
+        $this->setProcessTimeoutByArguments(array(Process::PROCESS_TIMEOUT => 3600))->shouldReturn(true);
+
+        $this->getTimeout()->shouldReturn((double) 3600);
+    }
 }