Fix tag migrations (#5028)

Author: dimasciput

bims/migrations/0493_copy_tags_to_tenants.py

@@ -63,8 +63,29 @@ def copy_tags_to_tenants(apps, schema_editor):
             table_exists = cursor.fetchone()[0]
 
             if not table_exists:
-                print(f"  Skipping {schema_name}: taggit_tag table doesn't exist yet. Run migrate_schemas first.")
-                continue
+                print(f"  Creating taggit tables in {schema_name} by copying from public schema...")
+
+                # Copy taggit_tag table structure (including constraints and indexes)
+                cursor.execute(f"""
+                    CREATE TABLE {schema_name}.taggit_tag
+                    (LIKE public.taggit_tag INCLUDING ALL)
+                """)
+
+                # Copy taggit_taggeditem table structure
+                cursor.execute(f"""
+                    CREATE TABLE {schema_name}.taggit_taggeditem
+                    (LIKE public.taggit_taggeditem INCLUDING ALL)
+                """)
+
+                # Recreate foreign key constraint to point to tenant schema
+                cursor.execute(f"""
+                    ALTER TABLE {schema_name}.taggit_taggeditem
+                    ADD CONSTRAINT taggit_taggeditem_tag_id_fkey
+                    FOREIGN KEY (tag_id) REFERENCES {schema_name}.taggit_tag(id)
+                    ON DELETE CASCADE DEFERRABLE INITIALLY DEFERRED
+                """)
+
+                print(f"  ✓ Created taggit tables in {schema_name}")
 
             # Check if tags have already been migrated to this tenant
             cursor.execute(f"""
@@ -128,10 +149,10 @@ def copy_tags_to_tenants(apps, schema_editor):
                 if cursor.fetchone():
                     items_skipped += 1
                 else:
-                    # Check if the content_type and object still exist in this tenant
+                    # Check if the content_type exists in public schema
                     cursor.execute(f"""
                         SELECT EXISTS (
-                            SELECT 1 FROM {schema_name}.django_content_type
+                            SELECT 1 FROM public.django_content_type
                             WHERE id = %s
                         )
                     """, [content_type_id])

bims/migrations/0495_rename_taxontag_id_to_tag_id.py

@@ -58,14 +58,80 @@ def rename_column_in_all_schemas(apps, schema_editor):
             has_tag_id = cursor.fetchone()[0]
 
             if has_taxontag_id and not has_tag_id:
-                print(f"  Renaming column in {schema_name}...")
+                print(f"  Updating {schema_name}...")
+
+                # Drop old foreign key constraint to bims_taxontag if it exists
+                cursor.execute(f"""
+                    SELECT constraint_name
+                    FROM information_schema.table_constraints
+                    WHERE table_schema = '{schema_name}'
+                    AND table_name = 'bims_taggroup_tags'
+                    AND constraint_type = 'FOREIGN KEY'
+                    AND constraint_name LIKE '%taxontag%'
+                """)
+                old_constraint = cursor.fetchone()
+                if old_constraint:
+                    constraint_name = old_constraint[0]
+                    print(f"    Dropping old FK constraint: {constraint_name}")
+                    cursor.execute(f"""
+                        ALTER TABLE {schema_name}.bims_taggroup_tags
+                        DROP CONSTRAINT {constraint_name}
+                    """)
+
+                # Rename column
                 cursor.execute(f"""
                     ALTER TABLE {schema_name}.bims_taggroup_tags
                     RENAME COLUMN taxontag_id TO tag_id
                 """)
-                print(f"  ✓ Renamed taxontag_id to tag_id in {schema_name}")
+
+                # Add new foreign key constraint to taggit_tag
+                print(f"    Adding new FK constraint to taggit_tag")
+                cursor.execute(f"""
+                    ALTER TABLE {schema_name}.bims_taggroup_tags
+                    ADD CONSTRAINT bims_taggroup_tags_tag_id_fkey
+                    FOREIGN KEY (tag_id) REFERENCES {schema_name}.taggit_tag(id)
+                    ON DELETE CASCADE DEFERRABLE INITIALLY DEFERRED
+                """)
+
+                print(f"  ✓ Updated {schema_name}")
             elif has_tag_id:
                 print(f"  Skipping {schema_name}: tag_id column already exists")
+                # Check if the correct FK constraint exists
+                cursor.execute(f"""
+                    SELECT constraint_name
+                    FROM information_schema.table_constraints
+                    WHERE table_schema = '{schema_name}'
+                    AND table_name = 'bims_taggroup_tags'
+                    AND constraint_type = 'FOREIGN KEY'
+                    AND constraint_name LIKE '%tag_id%'
+                """)
+                fk_exists = cursor.fetchone()
+
+                if not fk_exists:
+                    # Need to add the FK constraint even though column exists
+                    print(f"    Adding missing FK constraint to taggit_tag")
+                    # First drop any old constraint
+                    cursor.execute(f"""
+                        SELECT constraint_name
+                        FROM information_schema.table_constraints
+                        WHERE table_schema = '{schema_name}'
+                        AND table_name = 'bims_taggroup_tags'
+                        AND constraint_type = 'FOREIGN KEY'
+                        AND constraint_name LIKE '%taxontag%'
+                    """)
+                    old_constraint = cursor.fetchone()
+                    if old_constraint:
+                        cursor.execute(f"""
+                            ALTER TABLE {schema_name}.bims_taggroup_tags
+                            DROP CONSTRAINT {old_constraint[0]}
+                        """)
+
+                    cursor.execute(f"""
+                        ALTER TABLE {schema_name}.bims_taggroup_tags
+                        ADD CONSTRAINT bims_taggroup_tags_tag_id_fkey
+                        FOREIGN KEY (tag_id) REFERENCES {schema_name}.taggit_tag(id)
+                        ON DELETE CASCADE DEFERRABLE INITIALLY DEFERRED
+                    """)
             else:
                 print(f"  Skipping {schema_name}: taxontag_id column doesn't exist")