Fix Windows build: split syscall code into platform-specific files

Author: timlinux

CHANGELOG.md

@@ -5,7 +5,7 @@ All notable changes to Kartoza Screencaster will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [0.7.2] - 2026-01-25
+## [0.7.3] - 2026-01-25
 
 ### Fixed
 
@@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - CI now installs CGO dependencies for Linux systray builds
 - Debian package includes runtime deps: `libgtk-3-0`, `libayatana-appindicator3-1`
 - RPM package includes runtime deps: `gtk3`, `libayatana-appindicator-gtk3`
+- Fixed Windows build: split syscall code into platform-specific files
 
 ### Platform Notes
 | Platform | Systray Support | Notes |
@@ -198,7 +199,7 @@ Key syndication features:
 - Beautiful TUI interface
 - CLI mode for scripting
 
-[0.7.2]: https://github.com/kartoza/kartoza-screencaster/compare/v0.7.1...v0.7.2
+[0.7.3]: https://github.com/kartoza/kartoza-screencaster/compare/v0.7.1...v0.7.3
 [0.7.1]: https://github.com/kartoza/kartoza-screencaster/compare/v0.7.0...v0.7.1
 [0.7.0]: https://github.com/kartoza/kartoza-screencaster/compare/v0.6.1...v0.7.0
 [0.6.1]: https://github.com/kartoza/kartoza-screencaster/compare/v0.6.0...v0.6.1

flake.nix

@@ -10,7 +10,7 @@
     flake-utils.lib.eachDefaultSystem (system:
       let
         pkgs = nixpkgs.legacyPackages.${system};
-        version = "0.7.2";
+        version = "0.7.3";
 
         # MkDocs with Material theme for documentation
         mkdocsEnv = pkgs.python3.withPackages (ps: with ps; [

internal/terminal/process_unix.go

@@ -0,0 +1,28 @@
+//go:build !windows
+
+package terminal
+
+import (
+	"os/exec"
+	"syscall"
+)
+
+// setSysProcAttr sets Unix-specific process attributes
+func setSysProcAttr(cmd *exec.Cmd) {
+	cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}
+}
+
+// stopProcess sends signals to gracefully stop the process on Unix
+func stopProcess(cmd *exec.Cmd) error {
+	if cmd == nil || cmd.Process == nil {
+		return nil
+	}
+
+	// Send SIGTERM to stop process gracefully
+	if err := cmd.Process.Signal(syscall.SIGTERM); err != nil {
+		// If SIGTERM fails, try SIGINT (Ctrl+C)
+		cmd.Process.Signal(syscall.SIGINT)
+	}
+
+	return nil
+}

internal/terminal/process_windows.go

@@ -0,0 +1,23 @@
+//go:build windows
+
+package terminal
+
+import (
+	"os"
+	"os/exec"
+)
+
+// setSysProcAttr sets Windows-specific process attributes (no-op on Windows)
+func setSysProcAttr(cmd *exec.Cmd) {
+	// No equivalent on Windows - process groups work differently
+}
+
+// stopProcess kills the process on Windows
+func stopProcess(cmd *exec.Cmd) error {
+	if cmd == nil || cmd.Process == nil {
+		return nil
+	}
+
+	// On Windows, just kill the process directly
+	return cmd.Process.Signal(os.Kill)
+}

internal/terminal/terminal.go

@@ -6,7 +6,6 @@ import (
 	"os/exec"
 	"path/filepath"
 	"strconv"
-	"syscall"
 
 	"github.com/kartoza/kartoza-screencaster/internal/config"
 )
@@ -111,8 +110,8 @@ func (r *Recorder) Start(opts RecorderOptions) error {
 	r.cmd.Stdout = os.Stdout
 	r.cmd.Stderr = os.Stderr
 
-	// Start in a new process group so we can signal it
-	r.cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}
+	// Set platform-specific process attributes
+	setSysProcAttr(r.cmd)
 
 	if err := r.cmd.Start(); err != nil {
 		return fmt.Errorf("failed to start asciinema: %w", err)
@@ -133,11 +132,8 @@ func (r *Recorder) Stop() error {
 		return nil
 	}
 
-	// Send SIGTERM to stop asciinema gracefully
-	if err := r.cmd.Process.Signal(syscall.SIGTERM); err != nil {
-		// If SIGTERM fails, try SIGINT (Ctrl+C)
-		r.cmd.Process.Signal(syscall.SIGINT)
-	}
+	// Stop process using platform-specific method
+	stopProcess(r.cmd)
 
 	// Wait for process to finish
 	r.cmd.Wait()