Remove temporary dust prevention mechanism (#698)

someone235 · web-flow · commit fcd9c28f9b21 · 2025-06-30T13:18:30.000+03:00
* Remove temporary dust prevention mechanism

* Disable uninlined_format_args lint

* Apply workspace lints to all crates

* clippy
diff --git a/Cargo.toml b/Cargo.toml
@@ -338,3 +338,4 @@ strip = false
 
 [workspace.lints.clippy]
 empty_docs = "allow"
+uninlined_format_args = "allow"
diff --git a/components/addressmanager/Cargo.toml b/components/addressmanager/Cargo.toml
@@ -28,3 +28,6 @@ tokio.workspace = true
 
 [dev-dependencies]
 rv.workspace = true
+
+[lints]
+workspace = true
diff --git a/components/connectionmanager/Cargo.toml b/components/connectionmanager/Cargo.toml
@@ -20,4 +20,7 @@ kaspa-utils.workspace = true
 log.workspace = true
 parking_lot.workspace = true
 rand.workspace = true
-tokio.workspace = true
+tokio.workspace = true
+
+[lints]
+workspace = true
diff --git a/components/consensusmanager/Cargo.toml b/components/consensusmanager/Cargo.toml
@@ -23,3 +23,6 @@ log.workspace = true
 parking_lot.workspace = true
 rand.workspace = true
 tokio.workspace = true
+
+[lints]
+workspace = true
diff --git a/consensus/Cargo.toml b/consensus/Cargo.toml
@@ -68,3 +68,6 @@ harness = false
 [features]
 html_reports = []
 devnet-prealloc = ["kaspa-consensus-core/devnet-prealloc"]
+
+[lints]
+workspace = true
diff --git a/consensus/notify/Cargo.toml b/consensus/notify/Cargo.toml
@@ -23,3 +23,6 @@ log.workspace = true
 paste.workspace = true
 thiserror.workspace = true
 triggered.workspace = true
+
+[lints]
+workspace = true
diff --git a/core/Cargo.toml b/core/Cargo.toml
@@ -25,3 +25,6 @@ log4rs = { workspace = true, features = ["all_components", "gzip", "background_r
 num_cpus.workspace = true
 tokio = { workspace = true, features = ["rt", "macros", "rt-multi-thread", "time"] }
 anyhow = "1.0.97"
+
+[lints]
+workspace = true
diff --git a/crypto/hashes/Cargo.toml b/crypto/hashes/Cargo.toml
@@ -39,3 +39,6 @@ cc.workspace = true
 [[bench]]
 name = "bench"
 harness = false
+
+[lints]
+workspace = true
diff --git a/crypto/merkle/Cargo.toml b/crypto/merkle/Cargo.toml
@@ -11,3 +11,6 @@ repository.workspace = true
 
 [dependencies]
 kaspa-hashes.workspace = true
+
+[lints]
+workspace = true
diff --git a/crypto/muhash/Cargo.toml b/crypto/muhash/Cargo.toml
@@ -26,5 +26,9 @@ rand.workspace = true
 name = "bench"
 harness = false
 
-[lints.rust]
-unexpected_cfgs = { level = "warn", check-cfg = ['cfg(fuzzing)'] }
+[lints]
+rust = { unexpected_cfgs = { level = "warn", check-cfg = ['cfg(fuzzing)'] } }
+
+[lints.clippy]
+empty_docs = "allow"
+uninlined_format_args = "allow"
diff --git a/crypto/txscript/Cargo.toml b/crypto/txscript/Cargo.toml
@@ -51,3 +51,6 @@ serde_json.workspace = true
 [[bench]]
 name = "bench"
 harness = false
+
+[lints]
+workspace = true
diff --git a/crypto/txscript/errors/Cargo.toml b/crypto/txscript/errors/Cargo.toml
@@ -14,3 +14,6 @@ repository.workspace = true
 [dependencies]
 thiserror.workspace = true
 secp256k1.workspace = true
+
+[lints]
+workspace = true
diff --git a/daemon/Cargo.toml b/daemon/Cargo.toml
@@ -26,3 +26,6 @@ workflow-log.workspace = true
 workflow-node.workspace = true
 workflow-nw.workspace = true
 workflow-store.workspace = true
+
+[lints]
+workspace = true
diff --git a/database/Cargo.toml b/database/Cargo.toml
@@ -26,3 +26,6 @@ serde.workspace = true
 smallvec.workspace = true
 tempfile.workspace = true
 thiserror.workspace = true
+
+[lints]
+workspace = true
diff --git a/indexes/core/Cargo.toml b/indexes/core/Cargo.toml
@@ -27,4 +27,7 @@ triggered.workspace = true
 [dev-dependencies]
 # parking_lot.workspace = true
 # tokio = { workspace = true, features = ["rt", "macros"] }
-# rand = {workspace = true,  features = [ "small_rng" ]}
+# rand = {workspace = true,  features = [ "small_rng" ]}
+
+[lints]
+workspace = true
diff --git a/indexes/processor/Cargo.toml b/indexes/processor/Cargo.toml
@@ -35,4 +35,7 @@ triggered.workspace = true
 kaspa-consensus.workspace = true
 parking_lot.workspace = true
 tokio = { workspace = true, features = ["rt", "macros"] }
-rand = {workspace = true,  features = [ "small_rng" ]}
+rand = {workspace = true,  features = [ "small_rng" ]}
+
+[lints]
+workspace = true
diff --git a/indexes/utxoindex/Cargo.toml b/indexes/utxoindex/Cargo.toml
@@ -27,3 +27,6 @@ thiserror.workspace = true
 [dev-dependencies]
 kaspa-consensus.workspace = true
 rand = { workspace = true, features = ["small_rng"] }
+
+[lints]
+workspace = true
diff --git a/indexes/utxoindex/src/stores/indexed_utxos.rs b/indexes/utxoindex/src/stores/indexed_utxos.rs
@@ -213,7 +213,7 @@ impl UtxoSetByScriptPublicKeyStore for DbUtxoSetByScriptPublicKeyStore {
         let mut writer = DirectDbWriter::new(&self.db);
 
         let mut to_remove = utxo_entries.iter().flat_map(move |(script_public_key, compact_utxo_collection)| {
-            compact_utxo_collection.iter().map(move |(transaction_outpoint, _)| {
+            compact_utxo_collection.keys().map(move |transaction_outpoint| {
                 UtxoEntryFullAccessKey::new(
                     ScriptPublicKeyBucket::from(script_public_key),
                     TransactionOutpointKey::from(transaction_outpoint),
diff --git a/kaspad/Cargo.toml b/kaspad/Cargo.toml
@@ -67,3 +67,6 @@ serde_with = "3.7.0"
 heap = ["dhat", "kaspa-alloc/heap"]
 devnet-prealloc = ["kaspa-consensus/devnet-prealloc"]
 semaphore-trace = ["kaspa-utils/semaphore-trace"]
+
+[lints]
+workspace = true
diff --git a/math/Cargo.toml b/math/Cargo.toml
@@ -31,3 +31,6 @@ criterion.workspace = true
 [[bench]]
 name = "bench"
 harness = false
+
+[lints]
+workspace = true
diff --git a/metrics/core/Cargo.toml b/metrics/core/Cargo.toml
@@ -20,3 +20,6 @@ serde.workspace = true
 thiserror.workspace = true
 workflow-core.workspace = true
 workflow-log.workspace = true
+
+[lints]
+workspace = true
diff --git a/metrics/perf_monitor/Cargo.toml b/metrics/perf_monitor/Cargo.toml
@@ -16,3 +16,6 @@ portable-atomic.workspace = true
 thiserror.workspace = true
 tokio = { workspace = true, features = ["rt", "macros", "time"] }
 workflow-perf-monitor.workspace = true
+
+[lints]
+workspace = true
diff --git a/mining/Cargo.toml b/mining/Cargo.toml
@@ -39,3 +39,6 @@ secp256k1.workspace = true
 [[bench]]
 name = "bench"
 harness = false
+
+[lints]
+workspace = true
diff --git a/mining/errors/Cargo.toml b/mining/errors/Cargo.toml
@@ -14,3 +14,6 @@ repository.workspace = true
 [dependencies]
 thiserror.workspace = true
 kaspa-consensus-core.workspace = true
+
+[lints]
+workspace = true
diff --git a/mining/errors/src/mempool.rs b/mining/errors/src/mempool.rs
@@ -76,9 +76,6 @@ pub enum RuleError {
     #[error("transaction {0} is invalid")]
     RejectInvalid(TransactionId),
 
-    #[error("Rejected spam tx {0} from mempool")]
-    RejectSpamTransaction(TransactionId),
-
     #[error("Rejected tx {0} from mempool due to incomputable storage mass")]
     RejectStorageMassIncomputable(TransactionId),
 }
diff --git a/mining/src/mempool/validate_and_insert_transaction.rs b/mining/src/mempool/validate_and_insert_transaction.rs
@@ -152,17 +152,6 @@ impl Mempool {
     }
 
     fn validate_transaction_in_context(&self, transaction: &MutableTransaction) -> RuleResult<()> {
-        // TEMP: apply parts of go-kaspad mempool dust prevention patch
-        let has_coinbase_input = transaction.entries.iter().any(|e| e.as_ref().unwrap().is_coinbase);
-        let num_extra_outs = transaction.tx.outputs.len() as i64 - transaction.tx.inputs.len() as i64;
-        if !has_coinbase_input
-            && num_extra_outs > 2
-            && transaction.calculated_fee.unwrap() < num_extra_outs as u64 * kaspa_consensus_core::constants::SOMPI_PER_KASPA
-        {
-            kaspa_core::trace!("Rejected spam tx {} from mempool ({} outputs)", transaction.id(), transaction.tx.outputs.len());
-            return Err(RuleError::RejectSpamTransaction(transaction.id()));
-        }
-
         if !self.config.accept_non_standard {
             self.check_transaction_standard_in_context(transaction)?;
         }
diff --git a/notify/Cargo.toml b/notify/Cargo.toml
@@ -46,3 +46,6 @@ workflow-perf-monitor.workspace = true
 [[bench]]
 name = "bench"
 harness = false
+
+[lints]
+workspace = true
diff --git a/protocol/flows/Cargo.toml b/protocol/flows/Cargo.toml
@@ -37,3 +37,6 @@ tokio = { workspace = true, features = ["rt-multi-thread", "macros", "signal"] }
 tokio-stream = { workspace = true, features = ["net"] }
 uuid = { workspace = true, features = ["v4", "fast-rng"] }
 chrono.workspace = true
+
+[lints]
+workspace = true
diff --git a/protocol/flows/src/v5/txrelay/flow.rs b/protocol/flows/src/v5/txrelay/flow.rs
@@ -229,8 +229,7 @@ impl RelayTransactionsFlow {
                     // TODO: discuss a banning process
                     return Err(ProtocolError::MisbehavingPeer(format!("rejected invalid transaction {}", transaction_id)));
                 }
-                Err(MiningManagerError::MempoolError(RuleError::RejectSpamTransaction(_)))
-                | Err(MiningManagerError::MempoolError(RuleError::RejectNonStandard(..))) => {
+                Err(MiningManagerError::MempoolError(RuleError::RejectNonStandard(..))) => {
                     self.spam_counter += 1;
                     if self.spam_counter % 100 == 0 {
                         kaspa_core::warn!("Peer {} has shared {} spam/non-standard txs ({:?})", self.router, self.spam_counter, res);
diff --git a/protocol/mining/Cargo.toml b/protocol/mining/Cargo.toml
@@ -21,3 +21,6 @@ kaspa-utils.workspace = true
 kaspa-utils-tower.workspace = true
 log.workspace = true
 tokio.workspace = true
+
+[lints]
+workspace = true
diff --git a/protocol/p2p/Cargo.toml b/protocol/p2p/Cargo.toml
@@ -51,3 +51,6 @@ tonic-build = { workspace = true, features = ["prost"] }
 
 [dev-dependencies]
 hex.workspace = true
+
+[lints]
+workspace = true
diff --git a/rothschild/Cargo.toml b/rothschild/Cargo.toml
@@ -36,3 +36,6 @@ criterion.workspace = true
 [[bench]]
 name = "bench"
 harness = false
+
+[lints]
+workspace = true
diff --git a/rpc/grpc/client/Cargo.toml b/rpc/grpc/client/Cargo.toml
@@ -45,3 +45,6 @@ rustls.workspace = true
 
 [features]
 heap = []
+
+[lints]
+workspace = true
diff --git a/rpc/grpc/core/Cargo.toml b/rpc/grpc/core/Cargo.toml
@@ -37,3 +37,6 @@ workflow-core.workspace = true
 
 [build-dependencies]
 tonic-build = { workspace = true, features = ["prost"] }
+
+[lints]
+workspace = true
diff --git a/rpc/grpc/server/Cargo.toml b/rpc/grpc/server/Cargo.toml
@@ -43,3 +43,6 @@ rustls.workspace = true
 
 [dev-dependencies]
 kaspa-grpc-client.workspace = true
+
+[lints]
+workspace = true
diff --git a/rpc/macros/Cargo.toml b/rpc/macros/Cargo.toml
@@ -23,3 +23,6 @@ proc-macro2 = { version = "1.0.43" }
 quote = "1.0.21"
 regex.workspace = true
 syn = {version="1.0.99",features=["full","fold","extra-traits","parsing","proc-macro"]} # do not update!
+
+[lints]
+workspace = true
diff --git a/rpc/service/Cargo.toml b/rpc/service/Cargo.toml
@@ -34,4 +34,7 @@ async-trait.workspace = true
 log.workspace = true
 tokio.workspace = true
 triggered.workspace = true
-workflow-rpc.workspace = true
+workflow-rpc.workspace = true
+
+[lints]
+workspace = true
diff --git a/rpc/wrpc/client/Cargo.toml b/rpc/wrpc/client/Cargo.toml
@@ -53,4 +53,6 @@ workflow-log.workspace = true
 workflow-rpc.workspace = true
 workflow-serializer.workspace = true
 workflow-wasm.workspace = true
-rustls.workspace = true
+rustls.workspace = true
+[lints]
+workspace = true
diff --git a/rpc/wrpc/examples/simple_client/Cargo.toml b/rpc/wrpc/examples/simple_client/Cargo.toml
@@ -16,3 +16,6 @@ kaspa-rpc-core.workspace = true
 kaspa-wrpc-client.workspace = true
 tokio.workspace = true
 
+
+[lints]
+workspace = true
diff --git a/rpc/wrpc/examples/subscriber/Cargo.toml b/rpc/wrpc/examples/subscriber/Cargo.toml
@@ -20,3 +20,6 @@ tokio.workspace = true
 workflow-core.workspace = true
 workflow-log.workspace = true
 ctrlc.workspace = true
+
+[lints]
+workspace = true
diff --git a/rpc/wrpc/proxy/Cargo.toml b/rpc/wrpc/proxy/Cargo.toml
@@ -26,3 +26,6 @@ workflow-rpc.workspace = true
 
 [package.metadata.emanate.build]
 folder = "setup"
+
+[lints]
+workspace = true
diff --git a/rpc/wrpc/server/Cargo.toml b/rpc/wrpc/server/Cargo.toml
@@ -34,4 +34,6 @@ workflow-core.workspace = true
 workflow-log.workspace = true
 workflow-rpc.workspace = true
 workflow-serializer.workspace = true
-rustls.workspace = true
+rustls.workspace = true
+[lints]
+workspace = true
diff --git a/simpa/Cargo.toml b/simpa/Cargo.toml
@@ -40,3 +40,6 @@ tokio = { workspace = true, features = ["rt", "macros", "rt-multi-thread"] }
 [features]
 heap = ["dhat", "kaspa-alloc/heap"]
 semaphore-trace = ["kaspa-utils/semaphore-trace"]
+
+[lints]
+workspace = true
diff --git a/testing/integration/Cargo.toml b/testing/integration/Cargo.toml
@@ -75,3 +75,6 @@ kaspa-txscript-errors.workspace = true
 heap = ["dhat"]
 html_reports = []
 devnet-prealloc = ["kaspad/devnet-prealloc"]
+
+[lints]
+workspace = true
diff --git a/utils/Cargo.toml b/utils/Cargo.toml
@@ -53,3 +53,6 @@ harness = false
 
 [features]
 semaphore-trace = []
+
+[lints]
+workspace = true
diff --git a/utils/alloc/Cargo.toml b/utils/alloc/Cargo.toml
@@ -24,3 +24,6 @@ mimalloc = { git = "https://github.com/purpleprotocol/mimalloc_rust", rev = "eff
 heap = []
 
 [dependencies]
+
+[lints]
+workspace = true
diff --git a/utils/tower/Cargo.toml b/utils/tower/Cargo.toml
@@ -22,3 +22,6 @@ pin-project-lite.workspace = true
 tokio.workspace = true
 tower-http.workspace = true
 tower.workspace = true
+
+[lints]
+workspace = true
diff --git a/wallet/bip32/Cargo.toml b/wallet/bip32/Cargo.toml
@@ -35,3 +35,6 @@ kaspa-consensus-core.workspace = true
 
 [dev-dependencies]
 faster-hex.workspace = true
+
+[lints]
+workspace = true
diff --git a/wallet/macros/Cargo.toml b/wallet/macros/Cargo.toml
@@ -24,3 +24,6 @@ syn = {version="1.0.99",features=["full","fold","extra-traits","parsing","proc-m
 convert_case = "0.5.0"
 regex.workspace = true
 xxhash-rust = { workspace = true, features = ["xxh32"] }
+
+[lints]
+workspace = true
diff --git a/wallet/native/Cargo.toml b/wallet/native/Cargo.toml
@@ -19,3 +19,6 @@ kaspa-cli.workspace = true
 tokio.workspace = true
 workflow-log.workspace = true
 workflow-terminal.workspace = true
+
+[lints]
+workspace = true
diff --git a/wallet/pskt/Cargo.toml b/wallet/pskt/Cargo.toml
@@ -48,3 +48,6 @@ serde_json.workspace = true
 wasm-bindgen-test.workspace = true
 js-sys.workspace = true
 web-sys.workspace = true
+
+[lints]
+workspace = true
diff --git a/wallet/wasm/Cargo.toml b/wallet/wasm/Cargo.toml
diff --git a/wasm/Cargo.toml b/wasm/Cargo.toml

Original file line number	Diff line number	Diff line change
`@@ -338,3 +338,4 @@ strip = false`
`338`	`338`
`339`	`339`	`[workspace.lints.clippy]`
`340`	`340`	`empty_docs = "allow"`
	`341`	`+uninlined_format_args = "allow"`