FIx ruff check errors

Author: katelouie

tests/test_cli.py

@@ -10,15 +10,12 @@
 
 import tempfile
 from pathlib import Path
-from unittest.mock import MagicMock, patch
+from unittest.mock import patch
 
 import pytest
 from click.testing import CliRunner
 
 from stellium.cli import cli
-from stellium.cli.cache import cache_clear_cmd, cache_group, cache_info_cmd, cache_size_cmd
-from stellium.cli.chart import chart_from_registry_cmd, chart_group
-from stellium.cli.ephemeris import ephemeris_download_cmd, ephemeris_group, ephemeris_list_cmd
 from stellium.cli.ephemeris_download import (
     EPHEMERIS_BASE_URL,
     FILE_PATTERNS,
@@ -28,7 +25,6 @@
     get_required_files,
 )
 
-
 # ============================================================================
 # FIXTURES
 # ============================================================================
@@ -351,9 +347,7 @@ def test_ephemeris_download_confirmation(self, runner: CliRunner):
 
     def test_ephemeris_download_force(self, runner: CliRunner):
         """Test 'ephemeris download --force' skips confirmation."""
-        with patch(
-            "stellium.cli.ephemeris.download_file", return_value=True
-        ) as mock_download:
+        with patch("stellium.cli.ephemeris.download_file", return_value=True):
             with patch(
                 "stellium.cli.ephemeris.get_required_files",
                 return_value=["test_file.se1"],
@@ -369,9 +363,7 @@ def test_ephemeris_download_force(self, runner: CliRunner):
 
     def test_ephemeris_download_quiet(self, runner: CliRunner):
         """Test 'ephemeris download --quiet' suppresses output."""
-        with patch(
-            "stellium.cli.ephemeris.download_file", return_value=True
-        ) as mock_download:
+        with patch("stellium.cli.ephemeris.download_file", return_value=True):
             with patch(
                 "stellium.cli.ephemeris.get_required_files",
                 return_value=["test_file.se1"],
@@ -389,9 +381,7 @@ def test_ephemeris_download_quiet(self, runner: CliRunner):
 
     def test_ephemeris_download_with_years(self, runner: CliRunner):
         """Test 'ephemeris download --years' downloads specific range."""
-        with patch(
-            "stellium.cli.ephemeris.download_file", return_value=True
-        ) as mock_download:
+        with patch("stellium.cli.ephemeris.download_file", return_value=True):
             with patch(
                 "stellium.cli.ephemeris.get_required_files"
             ) as mock_get_files:
@@ -512,7 +502,7 @@ def test_file_patterns_structure(self):
         assert "moon" in FILE_PATTERNS
         assert "asteroids" in FILE_PATTERNS
 
-        for category, config in FILE_PATTERNS.items():
+        for _category, config in FILE_PATTERNS.items():
             assert "prefix" in config
             assert "description" in config
             assert "size_kb" in config

web/components/location_input.py

@@ -6,13 +6,12 @@
 """
 
 import asyncio
-from typing import Callable
+from collections.abc import Callable
 
 from config import COLORS
 from geopy.geocoders import Nominatim
 from nicegui import ui
 
-
 # Geocoder instance (reused for all queries)
 _geolocator = Nominatim(user_agent="stellium_web_autocomplete")
 
@@ -150,7 +149,7 @@ def create_suggestion_item(loc: dict):
             ui.element("div")
             .classes("px-3 py-2 cursor-pointer hover:bg-gray-100")
             .style(f"border-bottom: 1px solid {COLORS['border']};")
-            .on("click", lambda l=loc: select_location(l))
+            .on("click", lambda loc=loc: select_location(loc))
         ):
             # Short name (prominent)
             ui.label(loc["short_name"]).classes("text-sm font-medium").style(

web/components/notable_selector.py

@@ -6,6 +6,7 @@
 
 from config import COLORS
 from nicegui import ui
+
 from stellium.data import get_notable_registry
 
 
@@ -51,7 +52,7 @@ def on_change(e):
             on_change=on_change,
         )
         .classes("w-full")
-        .props(f'outlined dense options-dense use-input input-debounce="200"')
+        .props('outlined dense options-dense use-input input-debounce="200"')
         .props(f'placeholder="{placeholder}"')
     )
 

web/main.py

@@ -16,11 +16,11 @@
 
 from config import COLORS, FONTS, GOOGLE_FONTS_URL
 from nicegui import ui
+from pages.explore import create_explore_page
 from pages.home import create_home_page
 from pages.natal import create_natal_page
 from pages.relationships import create_relationships_page
 from pages.timing import create_timing_page
-from pages.explore import create_explore_page
 
 # =============================================================================
 # GLOBAL STYLES

web/pages/explore.py

@@ -22,7 +22,7 @@ def create_explore_page():
     all_notables = registry.get_all()
 
     # Get unique categories
-    categories = sorted(set(n.category for n in all_notables))
+    categories = sorted({n.category for n in all_notables})
 
     # Page state
     state = {

web/pages/natal.py

@@ -22,7 +22,6 @@
     FixedStarsComponent,
     MidpointCalculator,
 )
-from stellium.presentation import ReportBuilder
 from stellium.engines.houses import (
     AlcabitiusHouses,
     APCHouses,
@@ -44,6 +43,7 @@
     WholeSignHouses,
 )
 from stellium.engines.patterns import AspectPatternAnalyzer
+from stellium.presentation import ReportBuilder
 
 # House system mapping (all 18 systems)
 HOUSE_SYSTEM_MAP = {
@@ -324,8 +324,8 @@ def download_pdf():
             filename = f"{name_part}_natal_report.pdf"
 
             # For PDF with chart image, we need to save SVG to temp file
-            import tempfile
             import os
+            import tempfile
 
             chart_svg_path = None
             if rs.include_chart_image and chart_svg["content"]:

web/pages/relationships.py

@@ -25,7 +25,6 @@
 from stellium import ChartBuilder
 from stellium.core.comparison import ComparisonBuilder
 from stellium.core.synthesis import SynthesisBuilder
-from stellium.presentation import ReportBuilder
 from stellium.engines.houses import (
     AlcabitiusHouses,
     APCHouses,
@@ -46,6 +45,7 @@
     VehlowEqualHouses,
     WholeSignHouses,
 )
+from stellium.presentation import ReportBuilder
 
 # House system mapping (all 18 systems)
 HOUSE_SYSTEM_MAP = {
@@ -436,8 +436,8 @@ def download_pdf():
             name_part = f"{p1_name}_{p2_name}".replace(" ", "_").lower()
             filename = f"{name_part}_{state.chart_type}_report.pdf"
 
-            import tempfile
             import os
+            import tempfile
 
             chart_svg_path = None
             if rs.include_chart_image and chart_svg["content"]:

web/pages/timing.py

@@ -4,7 +4,6 @@
 Chart types for forecasting: Transits, Progressions, and Returns.
 """
 
-from datetime import datetime
 
 from components.chart_display import create_chart_actions, create_chart_display
 from components.header import create_header, create_nav
@@ -28,9 +27,6 @@
 # Stellium imports
 from stellium import ChartBuilder
 from stellium.core.comparison import ComparisonBuilder
-from stellium.presentation import ReportBuilder
-from stellium.returns import ReturnBuilder
-from stellium.utils.progressions import calculate_progressed_datetime
 from stellium.engines.houses import (
     AlcabitiusHouses,
     APCHouses,
@@ -51,6 +47,9 @@
     VehlowEqualHouses,
     WholeSignHouses,
 )
+from stellium.presentation import ReportBuilder
+from stellium.returns import ReturnBuilder
+from stellium.utils.progressions import calculate_progressed_datetime
 
 # House system mapping (all 18 systems)
 HOUSE_SYSTEM_MAP = {
@@ -142,7 +141,7 @@ def get_timing_placeholder():
                     f"color: {COLORS['text_muted']}"
                 )
                 ui.select(
-                    {planet: desc for planet, desc in RETURN_PLANETS},
+                    dict(RETURN_PLANETS),
                     value=state.return_planet,
                     on_change=lambda e: update_field("return_planet", e.value),
                 ).classes("w-full")
@@ -627,8 +626,8 @@ def download_pdf():
             name_part = state.natal.name.replace(" ", "_").lower() if state.natal.name else "chart"
             filename = f"{name_part}_{state.chart_type}_report.pdf"
 
-            import tempfile
             import os
+            import tempfile
 
             chart_svg_path = None
             if rs.include_chart_image and chart_svg["content"]: