fix

Author: katieperry4

.github/workflows/maas-bff-tests.yml

@@ -38,7 +38,7 @@ jobs:
 
       - name: Install envtest assets
         working-directory: packages/maas/bff
-        run: ./bin/setup-envtest-release-0.17 use 1.29.0 --bin-dir ./bin
+        run: ./bin/setup-envtest-release-0.19 use 1.29.3 --bin-dir ./bin
 
       - name: Test (BFF API)
         working-directory: packages/maas/bff

packages/maas/Makefile

@@ -40,8 +40,8 @@ GOLANGCI_LINT ?= $(LOCALBIN)/golangci-lint-$(GOLANGCI_LINT_VERSION)
 
 ## Tool Versions
 GOLANGCI_LINT_VERSION ?= v2.0.2
-ENVTEST_VERSION ?= release-0.17
-ENVTEST_K8S_VERSION ?= 1.29.0
+ENVTEST_VERSION ?= release-0.19
+ENVTEST_K8S_VERSION ?= 1.29.3
 
 .PHONY: envtest
 envtest: $(ENVTEST) ## Download setup-envtest locally if necessary.
@@ -78,7 +78,7 @@ test: fmt vet envtest
 	cd bff && \
 	ABS_BIN_DIR="$$(pwd)/../bin" && \
 	ASSETS_PATH="$$( $(ENVTEST) use $(ENVTEST_K8S_VERSION) --bin-dir "$$ABS_BIN_DIR" -p path )" && \
-	ENVTEST_ASSETS_DIR="$$(dirname "$$(dirname "$$ASSETS_PATH")")" \
+	ENVTEST_ASSETS="$$ASSETS_PATH" \
 	go test ./internal/api -v
 
 ############ Dev Environment ############

packages/maas/bff/Makefile

@@ -11,7 +11,7 @@ INSECURE_SKIP_VERIFY ?= false
 #frontend static assets root directory
 STATIC_ASSETS_DIR ?= ./static
 # ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
-ENVTEST_K8S_VERSION = 1.29.0
+ENVTEST_K8S_VERSION = 1.29.3
 LOG_LEVEL ?= info
 ALLOWED_ORIGINS ?= ""
 DEBUG ?= false
@@ -76,7 +76,7 @@ GOLANGCI_LINT ?= $(LOCALBIN)/golangci-lint-$(GOLANGCI_LINT_VERSION)
 
 ## Tool Versions
 GOLANGCI_LINT_VERSION ?= v2.0.2
-ENVTEST_VERSION ?= release-0.17
+ENVTEST_VERSION ?= release-0.19
 
 .PHONY: envtest
 envtest: $(ENVTEST) ## Download setup-envtest locally if necessary.

packages/maas/bff/internal/integrations/kubernetes/k8mocks/base_testenv.go

@@ -58,11 +58,13 @@ func SetupEnvTest(input TestEnvInput) (*envtest.Environment, kubernetes.Interfac
 	var binaryAssetsDir string
 	var projectRoot, err = getProjectRoot()
 
-	// Check for explicit envtest assets directory (used in Docker)
-	if envDir := os.Getenv("ENVTEST_ASSETS_DIR"); envDir != "" {
+	// Prefer ENVTEST_ASSETS (set by make test); fallback to ENVTEST_ASSETS_DIR or project root.
+	if envtestAssets := os.Getenv("ENVTEST_ASSETS"); envtestAssets != "" {
+		binaryAssetsDir = envtestAssets
+	} else if envDir := os.Getenv("ENVTEST_ASSETS_DIR"); envDir != "" {
 		// Construct full path with OS/ARCH suffix
 		binaryAssetsDir = filepath.Join(envDir, "k8s",
-			fmt.Sprintf("1.29.0-%s-%s", runtime.GOOS, runtime.GOARCH))
+			fmt.Sprintf("1.29.3-%s-%s", runtime.GOOS, runtime.GOARCH))
 	} else {
 		// Fall back to project root detection (local development)
 		projectRoot, err := getProjectRoot()
@@ -72,7 +74,7 @@ func SetupEnvTest(input TestEnvInput) (*envtest.Environment, kubernetes.Interfac
 			os.Exit(1)
 		}
 		binaryAssetsDir = filepath.Join(projectRoot, "bin", "k8s",
-			fmt.Sprintf("1.29.0-%s-%s", runtime.GOOS, runtime.GOARCH))
+			fmt.Sprintf("1.29.3-%s-%s", runtime.GOOS, runtime.GOARCH))
 	}
 
 	testEnv := &envtest.Environment{