fix: PVC resizing doesn't trigger a redeployment (opendatahub-io#4334)

* fix: PVC resizing doesn't trigger a redeployment

* one annotation solution

* updated tests

* fixed lint

* NIM isolation

* generic version

* fix: lint

* deleted comment

Author: mtalvi

frontend/src/api/k8s/pvcs.ts

@@ -20,10 +20,17 @@ export const assemblePvc = (
   namespace: string,
   editName?: string,
   hideFromUI?: boolean,
+  additionalAnnotations?: Record<string, string>, // Generic alternative to forceRedeploy
 ): PersistentVolumeClaimKind => {
   const { name: pvcName, description, size, storageClassName, accessMode } = data;
   const name = editName || data.k8sName || translateDisplayNameForK8s(pvcName);
 
+  const annotations: Record<string, string> = {
+    'openshift.io/display-name': pvcName.trim(),
+    ...(description && { 'openshift.io/description': description }),
+    ...(additionalAnnotations || {}),
+  };
+
   return {
     apiVersion: 'v1',
     kind: 'PersistentVolumeClaim',
@@ -35,10 +42,7 @@ export const assemblePvc = (
           [KnownLabels.DASHBOARD_RESOURCE]: 'true',
         },
       }),
-      annotations: {
-        'openshift.io/display-name': pvcName.trim(),
-        ...(description && { 'openshift.io/description': description }),
-      },
+      annotations,
     },
     spec: {
       accessModes: [accessMode ?? AccessMode.RWO],
@@ -70,8 +74,9 @@ export const createPvc = (
   namespace: string,
   opts?: K8sAPIOptions,
   hideFromUI?: boolean,
+  additionalAnnotations?: Record<string, string>,
 ): Promise<PersistentVolumeClaimKind> => {
-  const pvc = assemblePvc(data, namespace, undefined, hideFromUI);
+  const pvc = assemblePvc(data, namespace, undefined, hideFromUI, additionalAnnotations);
 
   return k8sCreateResource<PersistentVolumeClaimKind>(
     applyK8sAPIOptions({ model: PVCModel, resource: pvc }, opts),
@@ -84,8 +89,15 @@ export const updatePvc = (
   namespace: string,
   opts?: K8sAPIOptions,
   excludeSpec?: boolean,
+  additionalAnnotations?: Record<string, string>,
 ): Promise<PersistentVolumeClaimKind> => {
-  const pvc = assemblePvc(data, namespace, existingData.metadata.name);
+  const pvc = assemblePvc(
+    data,
+    namespace,
+    existingData.metadata.name,
+    undefined,
+    additionalAnnotations,
+  );
   const newData = excludeSpec
     ? {
         ...pvc,

frontend/src/pages/modelServing/screens/projects/NIMServiceModal/ManageNIMServingModal.tsx

@@ -329,7 +329,11 @@ const ManageNIMServingModal: React.FC<ManageNIMServingModalProps> = ({
             description: pvc.metadata.annotations?.description || '',
             storageClassName: pvc.spec.storageClassName,
           };
-          promises.push(updatePvc(updatePvcData, pvc, namespace, { dryRun: false }));
+          promises.push(
+            updatePvc(updatePvcData, pvc, namespace, { dryRun: false }, false, {
+              'runtimes.opendatahub.io/force-redeploy': new Date().toISOString(),
+            }),
+          );
         }
         return Promise.all(promises);
       })