Skip to content

Commit 282087d

Browse files
committed
hide search input for non-admins
1 parent ca13601 commit 282087d

File tree

2 files changed

+32
-29
lines changed

2 files changed

+32
-29
lines changed

packages/maas/frontend/src/app/pages/api-keys/AllApiKeysPage.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ const AllApiKeysPage: React.FC = () => {
2727
const [isModalOpen, setIsModalOpen] = React.useState(false);
2828
const [revokeApiKey, setRevokeApiKey] = React.useState<APIKey | undefined>(undefined);
2929

30-
// TODO: use this for hiding the username search for non-admins and for allowing admins to see all keys
31-
// eslint-disable-next-line @typescript-eslint/no-unused-vars
3230
const [isMaasAdmin] = useIsMaasAdmin();
3331

3432
const [filterData, setFilterData] = React.useState<ApiKeyFilterDataType>(initialApiKeyFilterData);
@@ -157,6 +155,7 @@ const AllApiKeysPage: React.FC = () => {
157155
isFetching={isFetching}
158156
toolbarContent={
159157
<ApiKeysToolbar
158+
isMaasAdmin={isMaasAdmin}
160159
setIsModalOpen={setIsModalOpen}
161160
filterData={filterData}
162161
localUsername={localUsername}

packages/maas/frontend/src/app/pages/api-keys/allKeys/ApiKeysToolbar.tsx

Lines changed: 31 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ type ApiKeysToolbarProps = {
2929
activeApiKeys: APIKey[];
3030
refresh: () => void;
3131
onClearFilters: () => void;
32+
isMaasAdmin: boolean;
3233
};
3334

3435
const ApiKeysToolbar: React.FC<ApiKeysToolbarProps> = ({
@@ -42,6 +43,7 @@ const ApiKeysToolbar: React.FC<ApiKeysToolbarProps> = ({
4243
activeApiKeys,
4344
refresh,
4445
onClearFilters,
46+
isMaasAdmin,
4547
}) => {
4648
const [isStatusSelectOpen, setIsStatusSelectOpen] = React.useState(false);
4749

@@ -109,34 +111,36 @@ const ApiKeysToolbar: React.FC<ApiKeysToolbarProps> = ({
109111
</SelectList>
110112
</Select>
111113
</ToolbarFilter>
112-
<ToolbarFilter
113-
labels={filterData.username ? [filterData.username] : []}
114-
deleteLabel={() => {
115-
setLocalUsername('');
116-
onUsernameChange('');
117-
}}
118-
categoryName="Username"
119-
>
120-
<Tooltip
121-
content="Please enter the full username"
122-
data-testid="username-filter-tooltip"
114+
{isMaasAdmin && (
115+
<ToolbarFilter
116+
labels={filterData.username ? [filterData.username] : []}
117+
deleteLabel={() => {
118+
setLocalUsername('');
119+
onUsernameChange('');
120+
}}
121+
categoryName="Username"
123122
>
124-
<SearchInput
125-
aria-label="Filter by username"
126-
placeholder="Filter by username"
127-
data-testid="username-filter-input"
128-
value={localUsername}
129-
onChange={(_event, value) => {
130-
setLocalUsername(value);
131-
}}
132-
onSearch={(_event, value) => onUsernameChange(value)}
133-
onClear={() => {
134-
setLocalUsername('');
135-
onUsernameChange('');
136-
}}
137-
/>
138-
</Tooltip>
139-
</ToolbarFilter>
123+
<Tooltip
124+
content="Please enter the full username"
125+
data-testid="username-filter-tooltip"
126+
>
127+
<SearchInput
128+
aria-label="Filter by username"
129+
placeholder="Filter by username"
130+
data-testid="username-filter-input"
131+
value={localUsername}
132+
onChange={(_event, value) => {
133+
setLocalUsername(value);
134+
}}
135+
onSearch={(_event, value) => onUsernameChange(value)}
136+
onClear={() => {
137+
setLocalUsername('');
138+
onUsernameChange('');
139+
}}
140+
/>
141+
</Tooltip>
142+
</ToolbarFilter>
143+
)}
140144
</ToolbarGroup>
141145
</ToolbarToggleGroup>
142146
<ToolbarGroup>

0 commit comments

Comments
 (0)