Skip to content

Commit 2984d23

Browse files
mturleyclaude
andauthored
Disable database type dropdown when editing model registry (opendatahub-io#6208)
When editing an existing model registry, the database type cannot be changed as this would be a breaking change to the existing database configuration. The dropdown is now disabled in edit mode while remaining editable when creating a new registry. Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
1 parent a81305a commit 2984d23

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

frontend/src/pages/modelRegistrySettings/CreateModal.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -462,6 +462,7 @@ const CreateModal: React.FC<CreateModalProps> = ({ onClose, refresh, modelRegist
462462
dataTestId="mr-database-type"
463463
toggleProps={{ id: 'mr-database-type-toggle' }}
464464
isFullWidth
465+
isDisabled={!!mr}
465466
options={databaseTypeOptions}
466467
value={databaseType}
467468
onChange={(key) => handleDatabaseTypeChange(key)}

packages/cypress/cypress/tests/mocked/modelRegistrySettings/modelRegistrySettings.cy.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1039,6 +1039,16 @@ describe('EditModelRegistry', () => {
10391039
});
10401040
});
10411041

1042+
it('should have database type dropdown disabled when editing', () => {
1043+
setupMocksForMRSettingAccess({});
1044+
modelRegistrySettings.visit(true);
1045+
modelRegistrySettings
1046+
.findModelRegistryRow('test-registry-1')
1047+
.findKebabAction('Edit model registry')
1048+
.click();
1049+
modelRegistrySettings.findDatabaseTypeDropdown().should('be.disabled');
1050+
});
1051+
10421052
it('Shows skeleton, when password is loading', () => {
10431053
setupMocksForMRSettingAccess({ hasDatabasePassword: false });
10441054
modelRegistrySettings.visit(true);

0 commit comments

Comments
 (0)