more

Author: katieperry4

packages/maas/bff/internal/models/maasmodelref.go

@@ -7,10 +7,14 @@ type CreateMaaSModelRefRequest struct {
 	ModelRef         ModelReference `json:"modelRef"`
 	EndpointOverride string         `json:"endpointOverride,omitempty"`
 	Uid              string         `json:"uid,omitempty"`
+	DisplayName      string         `json:"displayName,omitempty"`
+	Description      string         `json:"description,omitempty"`
 }
 
 // UpdateMaaSModelRefRequest is the request body for updating an existing MaaSModelRef.
 type UpdateMaaSModelRefRequest struct {
 	ModelRef         ModelReference `json:"modelRef"`
 	EndpointOverride string         `json:"endpointOverride,omitempty"`
+	DisplayName      string         `json:"displayName,omitempty"`
+	Description      string         `json:"description,omitempty"`
 }

packages/maas/bff/internal/models/subscription.go

@@ -80,11 +80,13 @@ type ModelReference struct {
 
 // MaaSModelRefSummary is the BFF representation of a MaaSModelRef CR.
 type MaaSModelRefSummary struct {
-	Name      string         `json:"name"`
-	Namespace string         `json:"namespace"`
-	ModelRef  ModelReference `json:"modelRef"`
-	Phase     string         `json:"phase,omitempty"`
-	Endpoint  string         `json:"endpoint,omitempty"`
+	Name        string         `json:"name"`
+	Namespace   string         `json:"namespace"`
+	ModelRef    ModelReference `json:"modelRef"`
+	Phase       string         `json:"phase,omitempty"`
+	Endpoint    string         `json:"endpoint,omitempty"`
+	DisplayName string         `json:"displayName,omitempty"`
+	Description string         `json:"description,omitempty"`
 }
 
 // CreateSubscriptionRequest is the request body for creating a new subscription.

packages/maas/bff/internal/repositories/maasmodelrefs.go

@@ -40,7 +40,7 @@ func (r *MaaSModelRefsRepository) CreateMaaSModelRef(ctx context.Context, reques
 
 	kubeClient := client.GetDynamicClient()
 
-	obj := buildModelRefUnstructured(request.Name, request.Namespace, request.ModelRef, request.EndpointOverride, request.Uid)
+	obj := buildModelRefUnstructured(request.Name, request.Namespace, request.ModelRef, request.EndpointOverride, request.Uid, request.DisplayName, request.Description)
 	created, err := kubeClient.Resource(constants.MaaSModelRefGvr).Namespace(request.Namespace).Create(ctx, obj, metav1.CreateOptions{})
 	if err != nil {
 		if k8sErrors.IsAlreadyExists(err) {
@@ -82,6 +82,22 @@ func (r *MaaSModelRefsRepository) UpdateMaaSModelRef(ctx context.Context, namesp
 	if request.EndpointOverride != "" {
 		existingSpec["endpointOverride"] = request.EndpointOverride
 	}
+
+	annotations := existing.GetAnnotations()
+	if annotations == nil {
+		annotations = map[string]string{}
+	}
+	if request.DisplayName != "" {
+		annotations[displayNameAnnotation] = request.DisplayName
+	} else {
+		delete(annotations, displayNameAnnotation)
+	}
+	if request.Description != "" {
+		annotations[descriptionAnnotation] = request.Description
+	} else {
+		delete(annotations, descriptionAnnotation)
+	}
+	existing.SetAnnotations(annotations)
 	existing.Object["spec"] = existingSpec
 
 	updated, err := kubeClient.Resource(constants.MaaSModelRefGvr).Namespace(namespace).Update(ctx, existing, metav1.UpdateOptions{})
@@ -113,7 +129,7 @@ func (r *MaaSModelRefsRepository) DeleteMaaSModelRef(ctx context.Context, namesp
 	return nil
 }
 
-func buildModelRefUnstructured(name, namespace string, modelRef models.ModelReference, endpointOverride string, uid string) *unstructured.Unstructured {
+func buildModelRefUnstructured(name, namespace string, modelRef models.ModelReference, endpointOverride string, uid string, displayName string, description string) *unstructured.Unstructured {
 	obj := &unstructured.Unstructured{}
 	obj.SetAPIVersion("maas.opendatahub.io/v1alpha1")
 	obj.SetKind("MaaSModelRef")
@@ -128,6 +144,10 @@ func buildModelRefUnstructured(name, namespace string, modelRef models.ModelRefe
 			BlockOwnerDeletion: &[]bool{false}[0],
 		},
 	})
+	obj.SetAnnotations(map[string]string{
+		"openshift.io/display-name": displayName,
+		"openshift.io/description":  description,
+	})
 
 	spec := map[string]interface{}{
 		"modelRef": map[string]interface{}{

packages/maas/bff/internal/repositories/subscriptions.go

@@ -15,6 +15,11 @@ import (
 	"github.com/opendatahub-io/maas-library/bff/internal/models"
 )
 
+const (
+	displayNameAnnotation = "openshift.io/display-name"
+	descriptionAnnotation = "openshift.io/description"
+)
+
 // SubscriptionsRepository handles subscription operations via the Kubernetes API.
 type SubscriptionsRepository struct {
 	logger     *slog.Logger
@@ -489,6 +494,9 @@ func convertUnstructuredToModelRefSummary(obj *unstructured.Unstructured) (*mode
 		Name:      obj.GetName(),
 		Namespace: obj.GetNamespace(),
 	}
+	annotations := obj.GetAnnotations()
+	summary.DisplayName = annotations[displayNameAnnotation]
+	summary.Description = annotations[descriptionAnnotation]
 
 	kind, _, _ := unstructured.NestedString(content, "spec", "modelRef", "kind")
 	name, _, _ := unstructured.NestedString(content, "spec", "modelRef", "name")

packages/maas/bff/openapi.yaml

@@ -1487,6 +1487,14 @@ components:
           type: string
           description: Endpoint URL for the model (from status)
           example: https://llama-2-7b-chat.example.com
+        displayName:
+          type: string
+          description: Human-readable display name (from openshift.io/display-name annotation)
+          example: Llama 2 7B Chat
+        description:
+          type: string
+          description: Human-readable description (from openshift.io/description annotation)
+          example: A conversational language model fine-tuned for chat use cases
       required:
         - name
         - namespace
@@ -1626,6 +1634,14 @@ components:
           type: string
           description: UID of the OwnerReference Resource
           example: ""
+        displayName:
+          type: string
+          description: Human-readable display name stored as openshift.io/display-name annotation
+          example: Granite 3 8B Instruct
+        description:
+          type: string
+          description: Human-readable description stored as openshift.io/description annotation
+          example: A high-performance instruction-tuned language model
       required:
         - name
         - namespace
@@ -1641,5 +1657,13 @@ components:
           type: string
           description: Optional endpoint URL override
           example: ""
+        displayName:
+          type: string
+          description: Human-readable display name stored as openshift.io/display-name annotation
+          example: Granite 3 8B Instruct
+        description:
+          type: string
+          description: Human-readable description stored as openshift.io/description annotation
+          example: A high-performance instruction-tuned language model
       required:
         - modelRef

packages/maas/frontend/src/app/api/maas-models.ts

@@ -53,6 +53,8 @@ export const createMaaSModelRef =
       namespace: '',
       modelRef: { kind: '', name: '' },
       uid: '',
+      displayName: '',
+      description: '',
     },
   ) =>
   (opts: APIOptions): Promise<MaaSModelRef> =>
@@ -70,7 +72,9 @@ export const updateMaaSModelRef =
   (
     namespace: string,
     name: string,
-    requestBody: UpdateMaaSModelRefRequest = { modelRef: { kind: '', name: '' } },
+    requestBody: UpdateMaaSModelRefRequest = {
+      modelRef: { kind: '', name: '' },
+    },
     hostPath = '',
   ) =>
   (opts: APIOptions): Promise<MaaSModelRef> =>

packages/maas/frontend/src/app/types/maas-model.ts

@@ -14,6 +14,8 @@ export type MaaSModelRef = {
   modelRef: ModelReference;
   phase?: string;
   endpoint?: string;
+  displayName?: string;
+  description?: string;
 };
 
 export type ModelReference = {
@@ -27,11 +29,15 @@ export type CreateMaaSModelRefRequest = {
   modelRef: ModelReference;
   endpointOverride?: string;
   uid?: string;
+  displayName?: string;
+  description?: string;
 };
 
 export type UpdateMaaSModelRefRequest = {
   modelRef: ModelReference;
   endpointOverride?: string;
+  displayName?: string;
+  description?: string;
 };
 
 export type DeleteMaaSModelRefResponse = {

packages/maas/frontend/src/odh/modelServingExtensions/modelDeploymentWizard/MaaSModelRef.tsx

@@ -2,7 +2,7 @@ import type { LLMdDeployment } from '@odh-dashboard/llmd-serving/types';
 import { createMaaSModelRef, deleteMaaSModelRef, updateMaaSModelRef } from '~/app/api/maas-models';
 import type { MaaSFieldValue } from './MaaSEndpointCheckbox';
 
-const LLMINFERENCESERVICE_KIND = 'llmisvc';
+const LLMINFERENCESERVICE_KIND = 'LLMInferenceService';
 
 /**
  * Post-deploy extension for the MaaS checkbox field.
@@ -25,6 +25,8 @@ export const applyMaaSModelRef = async (
   const { name, namespace, uid } = deployedModel.metadata;
   const { isChecked } = fieldData;
   const modelRef = { kind: LLMINFERENCESERVICE_KIND, name };
+  const displayName = deployedModel.metadata.annotations?.['openshift.io/display-name'] ?? name;
+  const description = deployedModel.metadata.annotations?.['openshift.io/description'] ?? '';
 
   if (existingDeployment) {
     if (!isChecked) {
@@ -39,7 +41,7 @@ export const applyMaaSModelRef = async (
       }
     } else {
       try {
-        await updateMaaSModelRef(namespace, name, { modelRef })({});
+        await updateMaaSModelRef(namespace, name, { modelRef, displayName, description })({});
       } catch (err) {
         // If the MaaSModelRef was somehow removed externally, create it fresh
         const message = err instanceof Error ? err.message : String(err);
@@ -49,6 +51,8 @@ export const applyMaaSModelRef = async (
             namespace,
             modelRef,
             uid,
+            displayName,
+            description,
           })({});
         } else {
           throw err;
@@ -61,6 +65,8 @@ export const applyMaaSModelRef = async (
       namespace,
       modelRef,
       uid,
+      displayName,
+      description,
     })({});
   }
 };

packages/model-serving/src/components/deploymentWizard/ModelDeploymentWizard.tsx

@@ -65,7 +65,6 @@ const ModelDeploymentWizard: React.FC<ModelDeploymentWizardProps> = ({
     project?.metadata.name,
     externalData,
   );
-  console.log('wizardFormData', wizardFormData);
   const validation = useModelDeploymentWizardValidation(
     wizardFormData.state,
     wizardFormData.fields,