Move 'Use existing settings' to top of Hardware Profile select list (opendatahub-io#4627)

* change order

* add unit test

* move to new describe block

* add not exist assertion

Author: d0w

frontend/src/concepts/hardwareProfiles/HardwareProfileSelect.tsx

@@ -176,7 +176,7 @@ const HardwareProfileSelect: React.FC<HardwareProfileSelectProps> = ({
 
     // allow usage of existing settings if no hardware profile is found
     if (allowExistingSettings) {
-      formattedOptions.push({
+      formattedOptions.unshift({
         key: EXISTING_SETTINGS_KEY,
         label: 'Use existing settings',
         description: 'Use existing resource requests/limits, tolerations, and node selectors.',

frontend/src/concepts/hardwareProfiles/__tests__/HardwareProfileSelect.spec.tsx

@@ -69,6 +69,7 @@ const renderComponent = (
   hardwareProfiles: HardwareProfileKind[],
   currentProject: ProjectKind,
   isKueueEnabled: boolean,
+  allowExistingSettings = false,
 ) => {
   useIsAreaAvailableMock.mockReturnValue({
     status: isKueueEnabled,
@@ -112,7 +113,7 @@ const renderComponent = (
         hardwareProfilesLoaded
         hardwareProfilesError={undefined}
         projectScopedHardwareProfiles={[[], true, undefined, () => Promise.resolve()]}
-        allowExistingSettings={false}
+        allowExistingSettings={allowExistingSettings}
         hardwareProfileConfig={hardwareProfileConfig}
         isHardwareProfileSupported={() => true}
         onChange={() => null}
@@ -161,3 +162,32 @@ describe('HardwareProfileSelect filtering', () => {
     expect(screen.getByText('Node Profile 2')).toBeInTheDocument();
   });
 });
+
+describe('HardwareProfileSelect - Use existing settings', () => {
+  it('should not show "Use existing settings" as the first option when allowExistingSettings is false', async () => {
+    const project = mockProjectK8sResource({});
+    renderComponent([nodeHardwareProfile, nodeHardwareProfile2], project, false, false);
+
+    await userEvent.click(screen.getByRole('button', { name: 'Options menu' }));
+
+    const options = screen.getAllByRole('option');
+    expect(screen.queryByText('Use existing settings')).not.toBeInTheDocument();
+    expect(options[0]).toHaveTextContent('Node Profile');
+    expect(options[1]).toHaveTextContent('Node Profile 2');
+  });
+
+  it('should show "Use existing settings" as the first option when allowExistingSettings is true', async () => {
+    const project = mockProjectK8sResource({});
+    project.metadata.labels ??= {};
+    project.metadata.labels[KnownLabels.KUEUE_MANAGED] = 'true';
+
+    renderComponent([nodeHardwareProfile, nodeHardwareProfile2], project, false, true);
+
+    await userEvent.click(screen.getByRole('button', { name: 'Options menu' }));
+
+    const options = screen.getAllByRole('option');
+    expect(options[0]).toHaveTextContent('Use existing settings');
+    expect(options[1]).toHaveTextContent('Node Profile');
+    expect(options[2]).toHaveTextContent('Node Profile 2');
+  });
+});