remove the other checkselfaccess

Author: katieperry4

packages/maas/bff/internal/integrations/kubernetes/client.go

@@ -17,5 +17,4 @@ type KubernetesClientInterface interface {
 	GetNamespaces(ctx context.Context, identity *RequestIdentity) ([]corev1.Namespace, error)
 	IsClusterAdmin(identity *RequestIdentity) (bool, error)
 	GetUser(identity *RequestIdentity) (string, error)
-	CheckSelfAccess(ctx context.Context, group, resource, verb, namespace string) (bool, error)
 }

packages/maas/bff/internal/integrations/kubernetes/internal_k8s_client.go

@@ -218,30 +218,6 @@ func (kc *InternalKubernetesClient) IsClusterAdmin(identity *RequestIdentity) (b
 	return false, nil
 }
 
-func (kc *InternalKubernetesClient) CheckSelfAccess(ctx context.Context, group, resource, verb, namespace string) (bool, error) {
-	ctx, cancel := context.WithTimeout(ctx, 10*time.Second)
-	defer cancel()
-
-	sar := &authv1.SelfSubjectAccessReview{
-		Spec: authv1.SelfSubjectAccessReviewSpec{
-			ResourceAttributes: &authv1.ResourceAttributes{
-				Group:     group,
-				Resource:  resource,
-				Verb:      verb,
-				Namespace: namespace,
-			},
-		},
-	}
-
-	resp, err := kc.Client.AuthorizationV1().SelfSubjectAccessReviews().Create(ctx, sar, metav1.CreateOptions{})
-	if err != nil {
-		kc.Logger.Error("failed to perform access review", "error", err)
-		return false, fmt.Errorf("failed to perform access review: %w", err)
-	}
-
-	return resp.Status.Allowed, nil
-}
-
 func (kc *InternalKubernetesClient) GetUser(identity *RequestIdentity) (string, error) {
 	// On internal client, we can use the identity from request directly
 	return identity.UserID, nil

packages/maas/bff/internal/integrations/kubernetes/token_k8s_client.go

@@ -55,7 +55,7 @@ func (kc *TokenKubernetesClient) IsClusterAdmin(_ *RequestIdentity) (bool, error
 }
 
 // NewTokenKubernetesClient creates a Kubernetes client using a user bearer token.
-func NewTokenKubernetesClient(token string, logger *slog.Logger) (KubernetesClientInterface, error) {
+func NewTokenKubernetesClient(token string, logger *slog.Logger) (*TokenKubernetesClient, error) {
 	baseConfig, err := helper.GetKubeconfig()
 	if err != nil {
 		logger.Error("failed to get kubeconfig", "error", err)