Skip to content

Commit df26861

Browse files
andrewballantyneandrewballantyne
authored
SME Coverage (opendatahub-io#4365)
* Initial work on adding OWNERS file coverage * AI Bots are cool -- minor corrections * significantly level up management smoothlness to the OWNERS files * General improvements to the list of owners & added some docs * Alphabeticalize the ALIASES file * Add labels to all the OWNERS files
1 parent 9089260 commit df26861

File tree

37 files changed

+501
-28
lines changed

37 files changed

+501
-28
lines changed

‎OWNERS‎

Lines changed: 2 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,6 @@
11
approvers:
22
- openshift-cherrypick-robot
3-
- andrewballantyne
4-
- lucferbux
5-
- alexcreasy
6-
- christianvogt
7-
- mturley
8-
- Gkrumbach07
9-
- emilys314
10-
- DaoDaoNoCode
11-
- antowaddle
12-
- manosnoam
13-
- FedeAlonso
14-
- Griffin-Sullivan
15-
- YuliaKrimerman
3+
- @general-approvers
164

175
reviewers:
18-
- alexcreasy
19-
- christianvogt
20-
- Gkrumbach07
21-
- lucferbux
22-
- DaoDaoNoCode
23-
- manaswinidas
24-
- pnaik1
25-
- ppadti
26-
- dpanshug
27-
- mturley
28-
- antowaddle
29-
- manosnoam
30-
- FedeAlonso
31-
- Griffin-Sullivan
32-
- YuliaKrimerman
6+
- @opendatahub-io/odh-dashboard-maintainers

‎OWNERS_ALIASES‎

Lines changed: 113 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,113 @@
1+
## Common conventions for this file
2+
##
3+
## - @opendatahub-io/odh-dashboard-owners is added to each approver group
4+
## - Has all the Admins of the repo
5+
## - This allows future no_parent_owners to have backups if absences
6+
## - Avoid removing this group so absences can always be worked through
7+
## - @opendatahub-io/odh-dashboard-maintainers is added to each reviewer group (by default)
8+
## - Has all the primary Dashboard developers
9+
## - This allows a default of any reviewer for any PR (only helps with bot auto-reviewer selection)
10+
## - You can change this to be a subset if you wish -- enforcing bot auto-reviewers to be specific people with knowledge in the area
11+
##
12+
## Rules to follow for usage for optimum experience
13+
## - OWNERS files are placed on-demand in sub folders
14+
## - "options: no_parent_owners: true" is needed to force SMEs in those areas
15+
## - Should include one of the repo's "labels" that start with `area/`
16+
## - Any folder without an OWNERS file works up until it finds one and uses that information
17+
## - Update any of the appovers & reviewers of your area as you see fit (seek managerial feedback if needed)
18+
## - Removal of users from approval areas is rarely necessary -- these are not scrum based, they are knowledge based
19+
20+
aliases:
21+
# If we need to override sub folders or temporarily grant access to the general approvers
22+
# This group is made up of users who have shown good review abilities & have attained good knowledge of the app
23+
general-approvers:
24+
- andrewballantyne
25+
- lucferbux
26+
- alexcreasy
27+
- christianvogt
28+
- mturley
29+
- Gkrumbach07
30+
- emilys314
31+
- DaoDaoNoCode
32+
- antowaddle
33+
- manosnoam
34+
- FedeAlonso
35+
- Griffin-Sullivan
36+
- YuliaKrimerman
37+
38+
# Agentic / RAG team
39+
agentic-rag-approvers:
40+
- @opendatahub-io/odh-dashboard-owners
41+
- alexcreasy
42+
agentic-rag-reviewers:
43+
- @opendatahub-io/odh-dashboard-maintainers
44+
45+
# AI Safety / Trusty team
46+
ai-safety-trusty-approvers:
47+
- @opendatahub-io/odh-dashboard-owners
48+
- alexcreasy
49+
ai-safety-trusty-reviewers:
50+
- @opendatahub-io/odh-dashboard-maintainers
51+
52+
# Connections & Connection Types team
53+
connections-approvers:
54+
- @opendatahub-io/odh-dashboard-owners
55+
- Griffin-Sullivan
56+
- emilys314
57+
connections-reviewers:
58+
- @opendatahub-io/odh-dashboard-maintainers
59+
60+
# Hardware Profiles team
61+
hardware-profiles-approvers:
62+
- @opendatahub-io/odh-dashboard-owners
63+
- Gkrumbach07
64+
hardware-profiles-reviewers:
65+
- @opendatahub-io/odh-dashboard-maintainers
66+
67+
# Model Registry & Model Catalog team
68+
model-registry-catalog-approvers:
69+
- @opendatahub-io/odh-dashboard-owners
70+
- mturley
71+
- YuliaKrimerman
72+
model-registry-catalog-reviewers:
73+
- @opendatahub-io/odh-dashboard-maintainers
74+
75+
# Model Serving & Model Metrics team
76+
model-serving-metrics-approvers:
77+
- @opendatahub-io/odh-dashboard-owners
78+
- Griffin-Sullivan
79+
- emilys314
80+
model-serving-metrics-reviewers:
81+
- @opendatahub-io/odh-dashboard-maintainers
82+
83+
# Pipelines team
84+
pipelines-approvers:
85+
- @opendatahub-io/odh-dashboard-owners
86+
- Gkrumbach07
87+
- DaoDaoNoCode
88+
pipelines-reviewers:
89+
- @opendatahub-io/odh-dashboard-maintainers
90+
91+
# General Dashboard infrastructure team; Plugins, Core Infrastructure, etc
92+
platform-approvers:
93+
- @opendatahub-io/odh-dashboard-owners
94+
- christianvogt
95+
- lucferbux
96+
platform-reviewers:
97+
- @opendatahub-io/odh-dashboard-maintainers
98+
99+
# Quality / E2E testing team
100+
quality-e2e-testing-approvers:
101+
- @opendatahub-io/odh-dashboard-owners
102+
- antowaddle
103+
- manosnoam
104+
quality-e2e-testing-reviewers:
105+
- @opendatahub-io/odh-dashboard-maintainers
106+
107+
# Workbenches (formerly Notebooks) team
108+
workbenches-approvers:
109+
- @opendatahub-io/odh-dashboard-owners
110+
- Gkrumbach07
111+
- DaoDaoNoCode
112+
workbenches-reviewers:
113+
- @opendatahub-io/odh-dashboard-maintainers

‎frontend/packages/kserve/OWNERS‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
options:
2+
no_parent_owners: true
3+
4+
approvers:
5+
- @model-serving-metrics-approvers
6+
7+
reviewers:
8+
- @model-serving-metrics-reviewers
9+
10+
labels:
11+
- area/model-serving

‎frontend/packages/model-registry/OWNERS‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
options:
2+
no_parent_owners: true
3+
4+
approvers:
5+
- @model-registry-catalog-approvers
6+
7+
reviewers:
8+
- @model-registry-catalog-reviewers
9+
10+
labels:
11+
- area/model-registry

‎frontend/packages/modelServing/OWNERS‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
options:
2+
no_parent_owners: true
3+
4+
approvers:
5+
- @model-serving-metrics-approvers
6+
7+
reviewers:
8+
- @model-serving-metrics-reviewers
9+
10+
labels:
11+
- area/model-serving

‎frontend/packages/plugin-core/OWNERS‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
options:
2+
no_parent_owners: true
3+
4+
approvers:
5+
- @platform-approvers
6+
7+
reviewers:
8+
- @platform-reviewers
9+
10+
labels:
11+
- area/platform

‎frontend/packages/template/OWNERS‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
options:
2+
no_parent_owners: true
3+
4+
approvers:
5+
- @platform-approvers
6+
7+
reviewers:
8+
- @platform-reviewers
9+
10+
labels:
11+
- area/platform

‎frontend/packages/tsconfig/OWNERS‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
options:
2+
no_parent_owners: true
3+
4+
approvers:
5+
- @platform-approvers
6+
7+
reviewers:
8+
- @platform-reviewers
9+
10+
labels:
11+
- area/platform

‎frontend/src/__tests__/cypress/OWNERS‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
options:
2+
no_parent_owners: true
3+
4+
approvers:
5+
- @quality-e2e-testing-approvers
6+
- @general-approvers
7+
8+
reviewers:
9+
- @quality-e2e-testing-reviewers
10+
11+
labels:
12+
- area/quality

‎frontend/src/api/modelRegistry/OWNERS‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
options:
2+
no_parent_owners: true
3+
4+
approvers:
5+
- @model-registry-catalog-approvers
6+
7+
reviewers:
8+
- @model-registry-catalog-reviewers
9+
10+
labels:
11+
- area/model-registry

0 commit comments

Comments
 (0)