fix: handle network errors in notebook controller catch blocks (opendatahub-io#6647)

Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>

Author: caponetto

frontend/src/pages/notebookController/ValidateNotebookNamespace.tsx

@@ -20,7 +20,9 @@ const ValidateNotebookNamespace: React.FC<ValidateNotebookNamespaceProps> = ({ c
         })
         .catch((e) => {
           const error = new Error(
-            `Error validating the role binding of your notebookNamespace; ${e.response.data.message}`,
+            `Error validating the role binding of your notebookNamespace; ${
+              e.response?.data?.message || e.message
+            }`,
           );
           setLoadError(error);
         });

frontend/src/pages/notebookController/screens/admin/__tests__/useCheckForAllowedUsers.spec.ts

@@ -51,4 +51,16 @@ describe('useCheckForAllowedUsers', () => {
     expect(renderResult).hookToStrictEqual([[], false, new Error('error1')]);
     expect(renderResult).hookToHaveUpdateCount(2);
   });
+
+  it('should handle error without response (network error)', async () => {
+    getAllowedUsersMock.mockRejectedValue(new Error('Network Error'));
+    const renderResult = testHook(useCheckForAllowedUsers)();
+
+    expect(renderResult).hookToStrictEqual([[], false, undefined]);
+    expect(renderResult).hookToHaveUpdateCount(1);
+
+    await renderResult.waitForNextUpdate();
+    expect(renderResult).hookToStrictEqual([[], false, new Error('Network Error')]);
+    expect(renderResult).hookToHaveUpdateCount(2);
+  });
 });

frontend/src/pages/notebookController/screens/admin/useCheckForAllowedUsers.ts

@@ -20,7 +20,7 @@ const useCheckForAllowedUsers = (): [
         setLoaded(true);
       })
       .catch((e) => {
-        setError(new Error(e.response.data.message));
+        setError(new Error(e.response?.data?.message || e.message));
         setLoaded(false);
       });
   }, [workbenchNamespace]);

frontend/src/services/notebookService.ts

@@ -8,7 +8,7 @@ export const getNotebook = (namespace: string, name: string): Promise<Notebook>
     .get(url)
     .then((response) => response.data)
     .catch((e) => {
-      throw new Error(e.response.data.message);
+      throw new Error(e.response?.data?.message || e.message);
     });
 };
 
@@ -23,13 +23,13 @@ export const getNotebookAndStatus = (
     .get(url)
     .then((response) => response.data)
     .catch((e) => {
-      if (e.response.status === 404) {
+      if (e.response?.status === 404) {
         return { notebook, isRunning: false };
       }
       /* eslint-disable-next-line no-console */
       console.error(
         'Checking notebook status failed, falling back on notebook check logic',
-        e.response.data.message,
+        e.response?.data?.message || e.message,
       );
       // Notebooks are unreliable to live status on replicas -- but if we have nothing else...
       const isRunning = !!(
@@ -48,7 +48,7 @@ export const enableNotebook = async (notebookData: NotebookData): Promise<Notebo
     .post(url, notebookData)
     .then((response) => response.data)
     .catch((e) => {
-      throw new Error(e.response.data.message);
+      throw new Error(e.response?.data?.message || e.message);
     });
 };
 
@@ -65,6 +65,6 @@ export const stopNotebook = (username?: string): Promise<Notebook> => {
     .patch(url, patch)
     .then((response) => response.data)
     .catch((e) => {
-      throw new Error(e.response.data.message);
+      throw new Error(e.response?.data?.message || e.message);
     });
 };