restore lexicographic sort to navigation group (opendatahub-io#5273)

Author: christianvogt

frontend/src/app/navigation/__tests__/NavSection.spec.tsx

@@ -1271,7 +1271,7 @@ describe('NavSection', () => {
           title: 'Without Group',
           href: '/withoutGroup',
           section: 'settings',
-          // No group property (should use default '8_default')
+          // No group property (should use default)
         },
         flags: {},
       };
@@ -1287,7 +1287,7 @@ describe('NavSection', () => {
         await userEvent.setup().click(expandButton);
       }
 
-      // Child with group should come first (1_early < 8_default)
+      // Child with group should come first
       await waitFor(() => {
         const items = screen.getAllByRole('link');
         expect(items[0]).toHaveTextContent('With Group');

frontend/src/app/navigation/utils.ts

@@ -1,26 +1,7 @@
 import { NavExtension } from '@odh-dashboard/plugin-core/extension-points';
 
-const DEFAULT_GROUP = '8_default';
+const DEFAULT_GROUP = '5_default';
 
-/** Comparison function for navigation items sorting. */
-export const compareNavItemGroups = <T extends NavExtension>(a: T, b: T): number => {
-  const groupA = a.properties.group || DEFAULT_GROUP;
-  const groupB = b.properties.group || DEFAULT_GROUP;
-
-  // Extract numeric prefix and suffix for proper sorting
-  const extractParts = (group: string) => {
-    const match = group.match(/^(\d+)_(.*)$/);
-    return match ? { num: parseInt(match[1], 10), suffix: match[2] } : { num: 0, suffix: group };
-  };
-
-  const partsA = extractParts(groupA);
-  const partsB = extractParts(groupB);
-
-  // First compare by numeric prefix
-  if (partsA.num !== partsB.num) {
-    return partsA.num - partsB.num;
-  }
-
-  // If numeric parts are equal, compare by suffix
-  return partsA.suffix.localeCompare(partsB.suffix);
-};
+/** Lexicographic comparison function for navigation items sorting. */
+export const compareNavItemGroups = <T extends NavExtension>(a: T, b: T): number =>
+  (a.properties.group || DEFAULT_GROUP).localeCompare(b.properties.group || DEFAULT_GROUP);

packages/plugin-core/src/extension-points/navigation.ts

@@ -40,7 +40,7 @@ export type NavItemProperties = {
   section?: string;
   /** Adds data attributes to the DOM. */
   dataAttributes?: { [key: string]: string };
-  /** Group are used to sort items lexographically. Unspecified items will be sorted into the '5_default' group. */
+  /** Group are used to sort items lexicographically. Unspecified items will be sorted into the '5_default' group. */
   group?: string;
   /** Icon reference for this item. */
   iconRef?: ComponentCodeRef;