Skip to content

Commit 54bd6dc

Browse files
authored
fix(cmake): standardize exported target name to container_system::container_system (#507)
Change EXPORT_NAME from container to container_system so consumers get container_system::container_system after find_package(container_system), following the <package>::<package> convention. Add container_system::container_system as canonical build-tree alias. Backward-compatible aliases (container_system::container and ContainerSystem::container) are preserved for existing consumers. Part of kcenon/vcpkg-registry#78
1 parent 8552632 commit 54bd6dc

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

CMakeLists.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -260,13 +260,14 @@ if(BUILD_WITH_COMMON_SYSTEM)
260260
endif()
261261

262262
# Create aliases for consistent naming and messaging system compatibility
263-
add_library(container_system::container ALIAS container_system)
263+
add_library(container_system::container_system ALIAS container_system) # Canonical <package>::<package>
264+
add_library(container_system::container ALIAS container_system) # Backward compatibility
264265
add_library(ContainerSystem::container ALIAS container_system) # Backward compatibility
265266
add_library(MessagingSystem::container ALIAS container_system) # For messaging system compatibility
266267

267268
# Set target properties
268269
set_target_properties(container_system PROPERTIES
269-
EXPORT_NAME container
270+
EXPORT_NAME container_system
270271
POSITION_INDEPENDENT_CODE ON
271272
CXX_STANDARD 20
272273
CXX_STANDARD_REQUIRED ON

cmake/container_system-config.cmake.in

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,11 @@ find_dependency(common_system CONFIG REQUIRED)
1313
# Include targets
1414
include("${CMAKE_CURRENT_LIST_DIR}/container_system-targets.cmake")
1515

16+
# Backward compatibility alias (container_system::container → container_system::container_system)
17+
if(NOT TARGET container_system::container)
18+
add_library(container_system::container ALIAS container_system::container_system)
19+
endif()
20+
1621
# Verify targets exist
1722
check_required_components(container_system)
1823

@@ -22,13 +27,13 @@ set(container_system_FOUND TRUE)
2227
# Provide information about the package
2328
set(container_system_VERSION @PROJECT_VERSION@)
2429
set(container_system_INCLUDE_DIRS "@PACKAGE_CMAKE_INSTALL_INCLUDEDIR@")
25-
set(container_system_LIBRARIES container_system::container)
30+
set(container_system_LIBRARIES container_system::container_system)
2631

2732
# Backward compatibility aliases (ContainerSystem:: → container_system::)
2833
if(NOT TARGET ContainerSystem::container)
2934
add_library(ContainerSystem::container INTERFACE IMPORTED)
3035
set_target_properties(ContainerSystem::container PROPERTIES
31-
INTERFACE_LINK_LIBRARIES container_system::container
36+
INTERFACE_LINK_LIBRARIES container_system::container_system
3237
)
3338
endif()
3439

0 commit comments

Comments
 (0)