Skip to content

Commit e07cba0

Browse files
kcenonkcenon
authored
refactor(internal): move QUIC protocol headers to internal (#631)
Move 18 QUIC protocol implementation headers and 2 QUIC unified adapters from public include directory to src/internal/. This reduces public API surface and hides implementation details. Changes: - Move protocols/quic/*.h (except connection_id.h) to internal - Move unified/adapters/quic_*.h to internal - Update include paths in all referencing files - Keep connection_id.h public (used by quic_session public API) Impact: - Public header count: 154 -> 134 (20 headers moved) - No breaking changes to public API - quic_facade.h remains the recommended entry point Part of #577 (EPIC: Facade pattern for header complexity) Closes #630
1 parent 545e620 commit e07cba0

57 files changed

Lines changed: 97 additions & 94 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎libs/network-quic/CMakeLists.txt‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ target_include_directories(network-quic
5050
$<INSTALL_INTERFACE:include>
5151
PRIVATE
5252
${CMAKE_CURRENT_SOURCE_DIR}/src
53+
# Access to internal headers (protocols/quic moved to src/internal)
54+
${CMAKE_CURRENT_SOURCE_DIR}/../../src
5355
)
5456

5557
##################################################

‎libs/network-quic/include/network_quic/internal/crypto.h‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
3939
* This header provides internal QUIC cryptographic types and utilities.
4040
*/
4141

42-
// Re-export QUIC crypto types from the main library
43-
#include "kcenon/network/protocols/quic/crypto.h"
44-
#include "kcenon/network/protocols/quic/keys.h"
45-
#include "kcenon/network/protocols/quic/session_ticket_store.h"
42+
// Re-export QUIC crypto types from the main library internal headers
43+
#include "internal/protocols/quic/crypto.h"
44+
#include "internal/protocols/quic/keys.h"
45+
#include "internal/protocols/quic/session_ticket_store.h"

‎libs/network-quic/include/network_quic/internal/stream.h‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
3939
* This header provides internal QUIC stream types and utilities.
4040
*/
4141

42-
// Re-export QUIC stream types from the main library
43-
#include "kcenon/network/protocols/quic/stream.h"
44-
#include "kcenon/network/protocols/quic/stream_manager.h"
45-
#include "kcenon/network/protocols/quic/flow_control.h"
42+
// Re-export QUIC stream types from the main library internal headers
43+
#include "internal/protocols/quic/stream.h"
44+
#include "internal/protocols/quic/stream_manager.h"
45+
#include "internal/protocols/quic/flow_control.h"

‎libs/network-quic/include/network_quic/quic_connection.h‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
4040
* including connection state, stream management, and protocol internals.
4141
*/
4242

43-
// Re-export the QUIC connection types from the main library
44-
#include "kcenon/network/protocols/quic/connection.h"
45-
#include "kcenon/network/protocols/quic/stream.h"
46-
#include "kcenon/network/protocols/quic/stream_manager.h"
43+
// Re-export the QUIC connection types from the main library internal headers
44+
// Note: These are internal implementation details exposed for advanced use cases
45+
#include "internal/protocols/quic/connection.h"
46+
#include "internal/protocols/quic/stream.h"
47+
#include "internal/protocols/quic/stream_manager.h"

‎libs/network-quic/src/quic_connection.cpp‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,10 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
4444

4545
#include "network_quic/quic_connection.h"
4646

47-
// Include the QUIC protocol internals
48-
#include "kcenon/network/protocols/quic/connection.h"
49-
#include "kcenon/network/protocols/quic/stream.h"
50-
#include "kcenon/network/protocols/quic/stream_manager.h"
47+
// Include the QUIC protocol internals (moved to internal)
48+
#include "internal/protocols/quic/connection.h"
49+
#include "internal/protocols/quic/stream.h"
50+
#include "internal/protocols/quic/stream_manager.h"
5151

5252
// This compilation unit serves as a linkage point for the QUIC connection
5353
// functionality when used as a standalone library. The actual implementation

‎src/experimental/quic_server.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
3737

3838
#include "kcenon/network/integration/logger_integration.h"
3939
#include "kcenon/network/metrics/network_metrics.h"
40-
#include "kcenon/network/protocols/quic/packet.h"
40+
#include "internal/protocols/quic/packet.h"
4141
#include "kcenon/network/session/quic_session.h"
4242
#include "internal/quic_socket.h"
4343

include/kcenon/network/protocols/quic/congestion_controller.h renamed to src/internal/protocols/quic/congestion_controller.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
3232

3333
#pragma once
3434

35-
#include "kcenon/network/protocols/quic/loss_detector.h"
36-
#include "kcenon/network/protocols/quic/rtt_estimator.h"
35+
#include "loss_detector.h"
36+
#include "rtt_estimator.h"
3737

3838
#include <chrono>
3939
#include <cstddef>

include/kcenon/network/protocols/quic/connection.h renamed to src/internal/protocols/quic/connection.h

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -32,18 +32,18 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
3232

3333
#pragma once
3434

35-
#include "kcenon/network/protocols/quic/congestion_controller.h"
35+
#include "congestion_controller.h"
3636
#include "kcenon/network/protocols/quic/connection_id.h"
37-
#include "kcenon/network/protocols/quic/connection_id_manager.h"
38-
#include "kcenon/network/protocols/quic/crypto.h"
39-
#include "kcenon/network/protocols/quic/flow_control.h"
40-
#include "kcenon/network/protocols/quic/frame.h"
41-
#include "kcenon/network/protocols/quic/loss_detector.h"
42-
#include "kcenon/network/protocols/quic/packet.h"
43-
#include "kcenon/network/protocols/quic/pmtud_controller.h"
44-
#include "kcenon/network/protocols/quic/rtt_estimator.h"
45-
#include "kcenon/network/protocols/quic/stream_manager.h"
46-
#include "kcenon/network/protocols/quic/transport_params.h"
37+
#include "connection_id_manager.h"
38+
#include "crypto.h"
39+
#include "flow_control.h"
40+
#include "frame.h"
41+
#include "loss_detector.h"
42+
#include "packet.h"
43+
#include "pmtud_controller.h"
44+
#include "rtt_estimator.h"
45+
#include "stream_manager.h"
46+
#include "transport_params.h"
4747
#include "kcenon/network/utils/result_types.h"
4848

4949
#include <chrono>

include/kcenon/network/protocols/quic/connection_id_manager.h renamed to src/internal/protocols/quic/connection_id_manager.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
3333
#pragma once
3434

3535
#include "kcenon/network/protocols/quic/connection_id.h"
36-
#include "kcenon/network/protocols/quic/frame_types.h"
36+
#include "frame_types.h"
3737
#include "kcenon/network/utils/result_types.h"
3838

3939
#include <array>

include/kcenon/network/protocols/quic/crypto.h renamed to src/internal/protocols/quic/crypto.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
3333
#pragma once
3434

3535
#include "kcenon/network/protocols/quic/connection_id.h"
36-
#include "kcenon/network/protocols/quic/keys.h"
36+
#include "keys.h"
3737
#include "kcenon/network/utils/result_types.h"
3838

3939
#include <cstdint>

0 commit comments

Comments
 (0)