Skip to content

Commit 36b3e38

Browse files
committed
handle multicluster-provider still being on kcp 0.28's SDK module
On-behalf-of: @SAP [email protected]
1 parent 5b73e8b commit 36b3e38

File tree

3 files changed

+15
-6
lines changed

3 files changed

+15
-6
lines changed

go.mod

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ require (
2525
github.com/spf13/pflag v1.0.10
2626
github.com/tidwall/gjson v1.18.0
2727
github.com/tidwall/sjson v1.2.5
28-
go.uber.org/zap v1.27.0
28+
go.uber.org/zap v1.27.1
2929
k8c.io/reconciler v0.5.0
3030
k8s.io/api v0.33.5
3131
k8s.io/apiextensions-apiserver v0.33.5
@@ -37,7 +37,7 @@ require (
3737
k8s.io/utils v0.0.0-20250604170112-4c0f3b243397
3838
sigs.k8s.io/controller-runtime v0.21.0
3939
sigs.k8s.io/multicluster-runtime v0.21.0-alpha.9
40-
sigs.k8s.io/yaml v1.4.0
40+
sigs.k8s.io/yaml v1.6.0
4141
)
4242

4343
require (
@@ -106,7 +106,6 @@ require (
106106
github.com/shopspring/decimal v1.4.0 // indirect
107107
github.com/spf13/cast v1.7.1 // indirect
108108
github.com/stoewer/go-strcase v1.3.0 // indirect
109-
github.com/stretchr/testify v1.11.1 // indirect
110109
github.com/tidwall/match v1.1.1 // indirect
111110
github.com/tidwall/pretty v1.2.1 // indirect
112111
github.com/x448/float16 v0.8.4 // indirect
@@ -124,6 +123,7 @@ require (
124123
go.opentelemetry.io/otel/trace v1.35.0 // indirect
125124
go.opentelemetry.io/proto/otlp v1.5.0 // indirect
126125
go.uber.org/multierr v1.11.0 // indirect
126+
go.yaml.in/yaml/v2 v2.4.2 // indirect
127127
go.yaml.in/yaml/v3 v3.0.4 // indirect
128128
golang.org/x/crypto v0.45.0 // indirect
129129
golang.org/x/exp v0.0.0-20251125195548-87e1e737ad39 // indirect

go.sum

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -278,8 +278,10 @@ go.uber.org/goleak v1.3.1-0.20241121203838-4ff5fa6529ee h1:uOMbcH1Dmxv45VkkpZQYo
278278
go.uber.org/goleak v1.3.1-0.20241121203838-4ff5fa6529ee/go.mod h1:CoHD4mav9JJNrW/WLlf7HGZPjdw8EucARQHekz1X6bE=
279279
go.uber.org/multierr v1.11.0 h1:blXXJkSxSSfBVBlC76pxqeO+LN3aDfLQo+309xJstO0=
280280
go.uber.org/multierr v1.11.0/go.mod h1:20+QtiLqy0Nd6FdQB9TLXag12DsQkrbs3htMFfDN80Y=
281-
go.uber.org/zap v1.27.0 h1:aJMhYGrd5QSmlpLMr2MftRKl7t8J8PTZPA732ud/XR8=
282-
go.uber.org/zap v1.27.0/go.mod h1:GB2qFLM7cTU87MWRP2mPIjqfIDnGu+VIO4V/SdhGo2E=
281+
go.uber.org/zap v1.27.1 h1:08RqriUEv8+ArZRYSTXy1LeBScaMpVSTBhCeaZYfMYc=
282+
go.uber.org/zap v1.27.1/go.mod h1:GB2qFLM7cTU87MWRP2mPIjqfIDnGu+VIO4V/SdhGo2E=
283+
go.yaml.in/yaml/v2 v2.4.2 h1:DzmwEr2rDGHl7lsFgAHxmNz/1NlQ7xLIrlN2h5d1eGI=
284+
go.yaml.in/yaml/v2 v2.4.2/go.mod h1:081UH+NErpNdqlCXm3TtEran0rJZGxAYx9hb/ELlsPU=
283285
go.yaml.in/yaml/v3 v3.0.4 h1:tfq32ie2Jv2UxXFdLJdh3jXuOzWiL1fo0bu/FbuKpbc=
284286
go.yaml.in/yaml/v3 v3.0.4/go.mod h1:DhzuOOF2ATzADvBadXxruRBLzYTpT36CKvDb3+aBEFg=
285287
golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
@@ -388,5 +390,6 @@ sigs.k8s.io/randfill v1.0.0 h1:JfjMILfT8A6RbawdsK2JXGBR5AQVfd+9TbzrlneTyrU=
388390
sigs.k8s.io/randfill v1.0.0/go.mod h1:XeLlZ/jmk4i1HRopwe7/aU3H5n1zNUcX6TM94b3QxOY=
389391
sigs.k8s.io/structured-merge-diff/v4 v4.6.0 h1:IUA9nvMmnKWcj5jl84xn+T5MnlZKThmUW1TdblaLVAc=
390392
sigs.k8s.io/structured-merge-diff/v4 v4.6.0/go.mod h1:dDy58f92j70zLsuZVuUX5Wp9vtxXpaZnkPGWeqDfCps=
391-
sigs.k8s.io/yaml v1.4.0 h1:Mk1wCc2gy/F0THH0TAp1QYyJNzRm2KCLy3o5ASXVI5E=
392393
sigs.k8s.io/yaml v1.4.0/go.mod h1:Ejl7/uTz7PSA4eKMyQCUTnhZYNmLIl+5c2lQPGR2BPY=
394+
sigs.k8s.io/yaml v1.6.0 h1:G8fkbMSAFqgEFgh4b1wmtzDnioxFCUgTZhlbj5P9QYs=
395+
sigs.k8s.io/yaml v1.6.0/go.mod h1:796bPqUfzR/0jLAl6XjHl3Ck7MiyVv8dbTdyT3/pMf4=

internal/controller/syncmanager/controller.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -277,6 +277,12 @@ func (r *Reconciler) ensureManager(log *zap.SugaredLogger, vwURL string) error {
277277

278278
provider, err := apiexportprovider.New(vwConfig, apiexportprovider.Options{
279279
Scheme: scheme,
280+
// The provider is still on kcp 0.28, hence it has an entirely differnt
281+
// kcp SDK module; to make sure the scheme we provide actually contains
282+
// the real, new 0.29-style kcp SDK, we have to override this object.
283+
// TODO: Once the multicluster-provider we use is also on 0.29+, this
284+
// shouldn't be needed anymore.
285+
ObjectToWatch: &kcpapisv1alpha1.APIBinding{},
280286
})
281287
if err != nil {
282288
return fmt.Errorf("failed to init apiexport provider: %w", err)

0 commit comments

Comments
 (0)