Skip to content

Commit 45e21fc

Browse files
committed
clarify subresource handling
On-behalf-of: @SAP [email protected]
1 parent 05155c6 commit 45e21fc

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

docs/content/faq.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ to the APIExport it manages:
4242
be any resource)
4343

4444
The syncagent will always overwrite the entire list of permission claims, i.e. you cannot have custom
45-
claims in an APIExport.
45+
claims in an APIExport managed by the api-syncagent.
4646

4747
## I am seeing errors in the agent logs, what's going on?
4848

internal/sync/syncer_related.go

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -143,12 +143,17 @@ func (s *ResourceSyncer) processRelatedResource(ctx context.Context, log *zap.Su
143143

144144
return dest, nil
145145
},
146-
// reloated resources have no subresources
146+
// Originally related resources were only ConfigMaps and Secrets, which do not have subresources;
147+
// nowadays we support arbitrary APIs for related resources, but for simplicity do not [yet?]
148+
// support syncing the subresources back. For this we would first need to figure out which
149+
// subresources even exist.
147150
subresources: nil,
148-
// only sync the status back if the object originates in kcp,
149-
// as the service side should never have to rely on new status infos coming
150-
// from the kcp side
151-
syncStatusBack: relRes.Origin == "kcp",
151+
// Theoretically we would only want to sync the status back if the related resource
152+
// originates in kcp, because it would be weird if the service provider relied on status
153+
// information provided to them by the consumer.
154+
// However since we do not know anything about subresources, we currently cannot enable this
155+
// feature at all.
156+
syncStatusBack: false,
152157
// if the origin is on the remote side, we want to add a finalizer to make
153158
// sure we can clean up properly
154159
blockSourceDeletion: relRes.Origin == "kcp",

0 commit comments

Comments
 (0)