Skip to content

Add support for CEL-based mutation rules #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xrstf wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add support for CEL-based mutation rules #125

xrstf wants to merge 3 commits into from
+397 −4

Conversation

@xrstf
Copy link
Contributor

@xrstf xrstf commented Dec 8, 2025 •
edited
Loading

Summary

This adds CEL-based mutations to the syncagent. CEl is nice because it allows for simply arithmetic and logic operations without the possibility to too much danger.

The implementation is quite simple: You configure a tuple of (path,expression) and then the agent will find the value at the given JSONPath in an object, process it using the CEL expression and then writes the resulting value back into the object. THe selected value and both full objects are available as variables in the expression.

What Type of PR Is This?

/kind feature

Related Issue(s)

Fixes #73

Release Notes

Add support for CEL-based mutation rules.

@kcp-ci-bot kcp-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Dec 8, 2025
@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Dec 8, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Dec 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from xrstf. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 8, 2025
@xrstf xrstf changed the title WIP CEl stuff, but need to stop because it seems to be kube 1.33+ only Add support for CEL-based mutation rules Dec 8, 2025
@xrstf
Copy link
Contributor Author

xrstf commented Dec 8, 2025

/test all

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 8, 2025
@xrstf
Copy link
Contributor Author

xrstf commented Dec 8, 2025

/kind feature

@kcp-ci-bot kcp-ci-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 8, 2025
@xrstf xrstf marked this pull request as ready for review December 8, 2025 14:56
@kcp-ci-bot kcp-ci-bot removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 8, 2025
@xrstf
Copy link
Contributor Author

xrstf commented Dec 8, 2025

/retest

@xrstf
Copy link
Contributor Author

xrstf commented Dec 8, 2025

/test pull-api-syncagent-test-e2e-kcp-0.27
/test pull-api-syncagent-test-e2e-kcp-0.28
/test pull-api-syncagent-test-e2e-kcp-0.29

4 similar comments
@xrstf
Copy link
Contributor Author

xrstf commented Dec 8, 2025

/test pull-api-syncagent-test-e2e-kcp-0.27
/test pull-api-syncagent-test-e2e-kcp-0.28
/test pull-api-syncagent-test-e2e-kcp-0.29

@xrstf
Copy link
Contributor Author

xrstf commented Dec 8, 2025

/test pull-api-syncagent-test-e2e-kcp-0.27
/test pull-api-syncagent-test-e2e-kcp-0.28
/test pull-api-syncagent-test-e2e-kcp-0.29

@xrstf
Copy link
Contributor Author

xrstf commented Dec 8, 2025

/test pull-api-syncagent-test-e2e-kcp-0.27
/test pull-api-syncagent-test-e2e-kcp-0.28
/test pull-api-syncagent-test-e2e-kcp-0.29

@xrstf
Copy link
Contributor Author

xrstf commented Dec 8, 2025

/test pull-api-syncagent-test-e2e-kcp-0.27
/test pull-api-syncagent-test-e2e-kcp-0.28
/test pull-api-syncagent-test-e2e-kcp-0.29

@xrstf
Copy link
Contributor Author

xrstf commented Dec 8, 2025

Okay it feels the tests are indeed much more stable now #jinxedit 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feature: Add CEL-based mutations

3 participants

@xrstf @kcp-ci-bot