- Use
make importsbefore committing any change to Go code. - Use
make modulesafter any change to ago.mod. - Run
make lint-fixbefore submitting a pull request. - Run the e2e tests before submitting a pull request.
- When possible, try to keep pull requests small and self-contained to make reviews easier.
- Do not update dependencies in
sdk/go.modunless necessary to keep the kcp-operator compiling. - Specifically do not attempt to manually bump the Go version in any
go.modfile in this project, instead letgo mod tidytake care of that.
- Lines in Markdown files should not exceed 100 characters (use explicit line breaks).
- Any change that impacts the reconciled resources (Deployments, Certificates, Secrets, ...) should have an accompanying e2e test.
- Use
make clean build test-e2e-with-kindfor running e2e tests.
- When generating a changelog for a new release, group all relevant pull requests based on their
kind/...label. Output these groups in descending order of importance. - Only include pull requests in the changelog that have a
release-noteblock in their descriptions on GitHub that is not empty orNONE. - List each pull request in the following form:
#<number>: <release note> (by @<author>)