Use 'core' group to replicate core API objects

Resources from core API use empty group, but this breaks
label selectors that end up being empty, and fail validation.
This commit replaces empty group with 'core'.

On-behalf-of: @SAP [email protected]
Signed-off-by: Robert Vasek <[email protected]>

Author: gman0

pkg/reconciler/cache/cachedresources/cachedresources_reconcile.go

@@ -140,6 +140,10 @@ func (c *Controller) deleteSelectedCacheResources(ctx context.Context, cluster l
 		Version:  cachedResource.Spec.Version,
 		Resource: cachedResource.Spec.Resource,
 	}
+	if gvr.Group == "" {
+		gvr.Group = "core"
+	}
+
 	selector := labels.SelectorFromSet(labels.Set{
 		replicationcontroller.LabelKeyObjectSchema: gvr.Version + "." + gvr.Resource + "." + gvr.Group,
 	})
@@ -161,6 +165,9 @@ func (c *Controller) listSelectedCacheResources(ctx context.Context, cluster log
 		Version:  cachedResource.Spec.Version,
 		Resource: cachedResource.Spec.Resource,
 	}
+	if gvr.Group == "" {
+		gvr.Group = "core"
+	}
 
 	selector := labels.SelectorFromSet(labels.Set{
 		replicationcontroller.LabelKeyObjectSchema: gvr.Version + "." + gvr.Resource + "." + gvr.Group,

pkg/reconciler/cache/cachedresources/replication/replication_reconcile.go

@@ -122,6 +122,9 @@ func (c *Controller) reconcile(ctx context.Context, gvrKey string) error {
 		},
 		createObject: func(ctx context.Context, cluster logicalcluster.Name, obj *unstructured.Unstructured) (*cachev1alpha1.CachedObject, error) {
 			gvr := obj.GroupVersionKind()
+			if gvr.Group == "" {
+				gvr.Group = "core"
+			}
 
 			objBytes, err := json.Marshal(obj)
 			if err != nil {
@@ -159,6 +162,9 @@ func (c *Controller) reconcile(ctx context.Context, gvrKey string) error {
 		},
 		updateObject: func(ctx context.Context, cluster logicalcluster.Name, obj *unstructured.Unstructured) (*cachev1alpha1.CachedObject, error) {
 			gvr := obj.GroupVersionKind()
+			if gvr.Group == "" {
+				gvr.Group = "core"
+			}
 
 			objBytes, err := json.Marshal(obj)
 			if err != nil {