Merge pull request #3521 from kcp-dev/mjudeikis/api.gen.debug

kcp-ci-bot · web-flow · commit aeb3c4cd6070 · 2025-08-11T20:24:14.000+02:00
Add more info to errors in api gen
diff --git a/pkg/reconciler/apis/apibinding/apibinding_reconcile.go b/pkg/reconciler/apis/apibinding/apibinding_reconcile.go
@@ -651,7 +651,7 @@ func generateCRD(schema *apisv1alpha1.APIResourceSchema) (*apiextensionsv1.Custo
 	}
 
 	if len(schema.Spec.Versions) > 1 && schema.Spec.Conversion == nil {
-		return nil, fmt.Errorf("multiple versions specified but no conversion strategy")
+		return nil, fmt.Errorf("multiple versions specified for %s but no conversion strategy", schema.Name)
 	}
 
 	if len(schema.Spec.Versions) > 1 {
diff --git a/sdk/apis/apis/v1alpha1/crd_to_apiresourceschema.go b/sdk/apis/apis/v1alpha1/crd_to_apiresourceschema.go
@@ -53,7 +53,7 @@ func CRDToAPIResourceSchema(crd *apiextensionsv1.CustomResourceDefinition, prefi
 	}
 
 	if len(crd.Spec.Versions) > 1 && crd.Spec.Conversion == nil {
-		return nil, fmt.Errorf("multiple versions specified but no conversion strategy")
+		return nil, fmt.Errorf("multiple versions specified for %s but no conversion strategy", crd.Name)
 	}
 
 	if crd.Spec.Conversion != nil {

Original file line number	Diff line number	Diff line change
`@@ -651,7 +651,7 @@ func generateCRD(schema apisv1alpha1.APIResourceSchema) (apiextensionsv1.Custo`
`651`	`651`	`}`
`652`	`652`
`653`	`653`	`if len(schema.Spec.Versions) > 1 && schema.Spec.Conversion == nil {`
`654`		`- return nil, fmt.Errorf("multiple versions specified but no conversion strategy")`
	`654`	`+ return nil, fmt.Errorf("multiple versions specified for %s but no conversion strategy", schema.Name)`
`655`	`655`	`}`
`656`	`656`
`657`	`657`	`if len(schema.Spec.Versions) > 1 {`
Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ func CRDToAPIResourceSchema(crd *apiextensionsv1.CustomResourceDefinition, prefi`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`if len(crd.Spec.Versions) > 1 && crd.Spec.Conversion == nil {`
`56`		`- return nil, fmt.Errorf("multiple versions specified but no conversion strategy")`
	`56`	`+ return nil, fmt.Errorf("multiple versions specified for %s but no conversion strategy", crd.Name)`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`if crd.Spec.Conversion != nil {`