more test fixing

Author: mjudeikis

pkg/server/options/flags.go

@@ -159,11 +159,14 @@ var (
 		"show-hidden-metrics-for-version", // The previous version for which you want to show hidden metrics. Only the previous minor version is meaningful, other values will not be allowed. The format is <major>.<minor>, e.g.: '1.16'. The purpose of this format is make sure you have the opportunity to notice if the next release hides additional metrics, rather than being surprised when they are permanently removed in the release after that.
 
 		// misc flags
-		"enable-logs-handler",          // If true, install a /logs handler for the apiserver logs.
-		"event-ttl",                    // Amount of time to retain events.
-		"max-connection-bytes-per-sec", // If non-zero, throttle each user connection to this number of bytes/sec. Currently only applies to long-running requests.
-		"proxy-client-cert-file",       // Client certificate used to prove the identity of the aggregator or kube-apiserver when it must call out during a request. This includes proxying requests to a user api-server and calling out to webhook admission plugins. It is expected that this cert includes a signature from the CA in the --requestheader-client-ca-file flag. That CA is published in the 'extension-apiserver-authentication' configmap in the kube-system namespace. Components receiving calls from kube-aggregator should use that CA to perform their half of the mutual TLS verification.
-		"proxy-client-key-file",        // Private key for the client certificate used to prove the identity of the aggregator or kube-apiserver when it must call out during a request. This includes proxying requests to a user api-server and calling out to webhook admission plugins.
+		"enable-logs-handler",                   // If true, install a /logs handler for the apiserver logs.
+		"event-ttl",                             // Amount of time to retain events.
+		"max-connection-bytes-per-sec",          // If non-zero, throttle each user connection to this number of bytes/sec. Currently only applies to long-running requests.
+		"proxy-client-cert-file",                // Client certificate used to prove the identity of the aggregator or kube-apiserver when it must call out during a request. This includes proxying requests to a user api-server and calling out to webhook admission plugins. It is expected that this cert includes a signature from the CA in the --requestheader-client-ca-file flag. That CA is published in the 'extension-apiserver-authentication' configmap in the kube-system namespace. Components receiving calls from kube-aggregator should use that CA to perform their half of the mutual TLS verification.
+		"proxy-client-key-file",                 // Private key for the client certificate used to prove the identity of the aggregator or kube-apiserver when it must call out during a request. This includes proxying requests to a user api-server and calling out to webhook admission plugins.
+		"coordinated-leadership-lease-duration", // The duration of the lease used for Coordinated Leader Election.
+		"coordinated-leadership-renew-deadline", // The deadline for renewing a coordinated leader election lease.
+		"coordinated-leadership-retry-period",   // The period for retrying to renew a coordinated leader election lease.
 	)
 
 	disallowedFlags = sets.New[string](
@@ -182,10 +185,12 @@ var (
 		"enable-garbage-collector",  // Enables the generic garbage collector. MUST be synced with the corresponding flag of the kube-controller-manager.
 
 		// admission flags
-		"admission-control-config-file", // File with admission control configuration.
-		"disable-admission-plugins",     // admission plugins that should be disabled although they are in the default enabled plugins list (NamespaceLifecycle). Comma-delimited list of admission plugins: MutatingAdmissionWebhook, NamespaceLifecycle, ValidatingAdmissionWebhook. The order of plugins in this flag does not matter.
-		"enable-admission-plugins",      // admission plugins that should be enabled in addition to default enabled ones (NamespaceLifecycle). Comma-delimited list of admission plugins: MutatingAdmissionWebhook, NamespaceLifecycle, ValidatingAdmissionWebhook. The order of plugins in this flag does not matter.
-		"admission-control",             // Deprecated: Use --enable-admission-plugins or --disable-admission-plugins instead. Will be removed in a future version.
+		"default-not-ready-toleration-seconds",   // Indicates the tolerationSeconds of the toleration for notReady:NoExecute that is added by default to every pod that does not already have such a toleration.
+		"default-unreachable-toleration-seconds", // Indicates the tolerationSeconds of the toleration for unreachable:NoExecute that is added by default to every pod that does not already have such a toleration.
+		"admission-control-config-file",          // File with admission control configuration.
+		"disable-admission-plugins",              // admission plugins that should be disabled although they are in the default enabled plugins list (NamespaceLifecycle). Comma-delimited list of admission plugins: MutatingAdmissionWebhook, NamespaceLifecycle, ValidatingAdmissionWebhook. The order of plugins in this flag does not matter.
+		"enable-admission-plugins",               // admission plugins that should be enabled in addition to default enabled ones (NamespaceLifecycle). Comma-delimited list of admission plugins: MutatingAdmissionWebhook, NamespaceLifecycle, ValidatingAdmissionWebhook. The order of plugins in this flag does not matter.
+		"admission-control",                      // Deprecated: Use --enable-admission-plugins or --disable-admission-plugins instead. Will be removed in a future version.
 
 		// egress selector flags
 		"egress-selector-config-file", // File with apiserver egress selector configuration.

pkg/virtual/framework/internalapis/fixtures/configmaps.yaml

@@ -1,5 +1,4 @@
 metadata:
-  creationTimestamp: null
   name: internal.configmaps.core
 spec:
   group: ""

pkg/virtual/framework/internalapis/fixtures/namespaces.yaml

@@ -1,5 +1,4 @@
 metadata:
-  creationTimestamp: null
   name: internal.namespaces.core
 spec:
   group: ""

pkg/virtual/framework/internalapis/fixtures/workspaces.yaml

@@ -1,5 +1,4 @@
 metadata:
-  creationTimestamp: null
   name: internal.workspaces.tenancy.kcp.io
 spec:
   group: tenancy.kcp.io

staging/src/github.com/kcp-dev/cli/pkg/crd/plugin/snapshot_test.go

@@ -56,7 +56,6 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.5.0
-  creationTimestamp: null
   name: endpoints.core
 spec:
   group: ""
@@ -205,7 +204,6 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.5.0
-  creationTimestamp: null
   name: services.core
 spec:
   group: ""
@@ -362,7 +360,6 @@ spec:
 var expectedYAML = `apiVersion: apis.kcp.io/v1alpha1
 kind: APIResourceSchema
 metadata:
-  creationTimestamp: null
   name: testing.endpoints.core
 spec:
   conversion:
@@ -583,7 +580,6 @@ spec:
 apiVersion: apis.kcp.io/v1alpha1
 kind: APIResourceSchema
 metadata:
-  creationTimestamp: null
   name: testing.services.core
 spec:
   conversion:

staging/src/github.com/kcp-dev/sdk/apis/apis/v1alpha2/validation_test.go

@@ -155,10 +155,10 @@ func TestValidateAPIBindingPermissionClaims(t *testing.T) {
 				},
 			},
 			wantErrs: []string{
-				"spec.permissionClaims[0].selector.matchLabels: Invalid value: v1alpha2.PermissionClaimSelector{LabelSelector:v1.LabelSelector{MatchLabels:map[string]string{\"test\":\"test\"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}, MatchAll:true}: matchLabels cannot be used with matchAll",
-				"spec.permissionClaims[1].selector.matchExpressions: Invalid value: v1alpha2.PermissionClaimSelector{LabelSelector:v1.LabelSelector{MatchLabels:map[string]string(nil), MatchExpressions:[]v1.LabelSelectorRequirement{v1.LabelSelectorRequirement{Key:\"test\", Operator:\"In\", Values:[]string{\"test\"}}}}, MatchAll:true}: matchExpressions cannot be used with matchAll",
-				"spec.permissionClaims[2].selector.matchExpressions: Invalid value: v1alpha2.PermissionClaimSelector{LabelSelector:v1.LabelSelector{MatchLabels:map[string]string{\"test\":\"test\"}, MatchExpressions:[]v1.LabelSelectorRequirement{v1.LabelSelectorRequirement{Key:\"test\", Operator:\"In\", Values:[]string{\"test\"}}}}, MatchAll:true}: matchExpressions cannot be used with matchAll",
-				"spec.permissionClaims[2].selector.matchLabels: Invalid value: v1alpha2.PermissionClaimSelector{LabelSelector:v1.LabelSelector{MatchLabels:map[string]string{\"test\":\"test\"}, MatchExpressions:[]v1.LabelSelectorRequirement{v1.LabelSelectorRequirement{Key:\"test\", Operator:\"In\", Values:[]string{\"test\"}}}}, MatchAll:true}: matchLabels cannot be used with matchAll",
+				"spec.permissionClaims[0].selector.matchLabels: Invalid value: {\"matchLabels\":{\"test\":\"test\"},\"matchAll\":true}: matchLabels cannot be used with matchAll",
+				"spec.permissionClaims[1].selector.matchExpressions: Invalid value: {\"matchExpressions\":[{\"key\":\"test\",\"operator\":\"In\",\"values\":[\"test\"]}],\"matchAll\":true}: matchExpressions cannot be used with matchAll",
+				"spec.permissionClaims[2].selector.matchExpressions: Invalid value: {\"matchLabels\":{\"test\":\"test\"},\"matchExpressions\":[{\"key\":\"test\",\"operator\":\"In\",\"values\":[\"test\"]}],\"matchAll\":true}: matchExpressions cannot be used with matchAll",
+				"spec.permissionClaims[2].selector.matchLabels: Invalid value: {\"matchLabels\":{\"test\":\"test\"},\"matchExpressions\":[{\"key\":\"test\",\"operator\":\"In\",\"values\":[\"test\"]}],\"matchAll\":true}: matchLabels cannot be used with matchAll",
 			},
 		},
 	}