Skip to content

🌱 Add per-cluster static endpoint filter/handler #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

🌱 Add per-cluster static endpoint filter/handler #2485

wants to merge 1 commit into from

Conversation

vincepri
Copy link
Contributor

@vincepri vincepri commented Dec 13, 2022 •
edited
Loading

Summary

Adds support to handle well-known endpoints like
/healthz /livez /readyz and /version.

The requests is rewritten to point to the root path instead of a cluster
specific one.

Related issue(s)

Fixes #2036

@vincepri
Add per-cluster static endpoint filter/handler
f479d5e 
Adds support to handle well-known endpoints like
/healthz /livez /readyz and /version.

The requests is rewritten to point to the root path instead of a cluster
specific one.

Signed-off-by: Vince Prignano <[email protected]>
@openshift-ci openshift-ci bot requested review from ncdc and sttts December 13, 2022 20:03
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ncdc for approval by writing /assign @ncdc in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vincepri vincepri changed the title Add per-cluster static endpoint filter/handler 🌱 Add per-cluster static endpoint filter/handler Dec 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2022

@vincepri: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-sharded f479d5e link true /test e2e-sharded
ci/prow/e2e-shared f479d5e link true /test e2e-shared
ci/prow/e2e f479d5e link true /test e2e
ci/prow/e2e-multiple-runs f479d5e link true /test e2e-multiple-runs

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vincepri
Copy link
Contributor Author

/hold

This might actually not be needed at all, the rewriting is already handled in filters.WithScopeCluster — The request seems to just not go through 🤔

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2022
@vincepri vincepri closed this Dec 13, 2022
@vincepri vincepri deleted the workspace-static-endpoints branch December 13, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdc ncdc Awaiting requested review from ncdc

@sttts sttts Awaiting requested review from sttts

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: make /readyz /live /healthz /version available in every workspace
1 participant
@vincepri