bug: create-workspace plugin does not correctly install via krew

[SimonTheLeg]

Describe the bug

If you install the create-workspace plugin via krew it does not work properly. The reason for this is that it gets installed as kubectl-create_workspace instead of the correct format for kubectl create plugins, which is kubectl-create-workspace (hyphen instead of underscore)

here is the output from ls

kubectl-create_workspace -> /Users/lsviben/.krew/store/create-workspace/v0.29.1/bin/kubectl-create-workspace

The binary name itself is correct, but for some reason krew replaces in the symlink (which is in $PATH) the hyphen with an underscore during installation of the plugin.

Steps To Reproduce

kubectl krew index add kcp-dev https://github.com/kcp-dev/krew-index.git
kubectl krew install kcp-dev/create-workspace

Expected Behaviour

plugin should be installed correctly

Additional Context

I am unsure if we need to fix something on our crew index,, there the name is correct. Or if this is something we need to report to krew. For now just dropping in the issue so we can have a more detailed look at it.

[SimonTheLeg]

seems to be an issue within krew, which is being tracked here kubernetes-sigs/krew#865